[16.0][REF] shopfloor_reception: reuse set_destination in _set_quantity__by_location - #1244
Open
nicolas-delbovier-acsone wants to merge 3 commits into
Open
Conversation
…_location Replaces duplicated and incomplete destination assignment logic in `_set_quantity__by_location` with existing `process_without_pack` and `set_destination` service methods. Using the existing `set_destination` method ensures consistent behavior, validation, and confirmation checks across the reception workflow instead of maintaining duplicated logic.
Contributor
|
Hi @JuMiSanAr, @mmequignon, |
OCA-git-bot
added
series:16.0
mod:shopfloor_reception
OCA-git-bot
added
the
mod:shopfloor_reception_putinpack_restriction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The way the code dealt with scanning a location from the "set_quantity" state was incorrect.
It did not split the line nor set it as
shopfloor_unloaded=True@jbaudoux