Skip to content

[20.0][MIG] server_environment_ir_config_parameter: Migration to 20.0 - #308

Open
rven wants to merge 35 commits into
OCA:20.0from
DynAppsNV:20.0-mig-server_environment_ir_config_parameter
Open

rven wants to merge 35 commits into
OCA:20.0from
DynAppsNV:20.0-mig-server_environment_ir_config_parameter

Conversation

@rven

@rven rven commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Standard migration to 20.0. Depends on #307.

get_param/set_param are removed in 20.0; the override moves to _get, used by the new typed get_*/set_* API. Tests ported.

Changes reviewed and tested by me.

Assisted-by: Claude Opus 5.5

sbidoul and others added 30 commits October 5, 2026 11:14
… values

This is much more robust that raising an error, and let modules
load ir.config_parameter from xml data files, while still enforcing
values from the config files.
Odoo loads modules that contain static directory, so it wanted to load server_environment_files but it does not exist
Without this sudo get_param would fail when the first user reading a parameter that has changed in the configuration file does not have write access to system parameters.
Manual forward port of 11.0 migration commit by Thierry Ducrest.
…arameter list and form views the new field is_environment, and make the key and values readonly if checked
fix a conflict between this module and mail which overrides the reading
of some mail related system parameters
Currently translated at 100.0% (4 of 4 strings)

Translation: server-env-16.0/server-env-16.0-server_environment_ir_config_parameter
Translate-URL: https://translation.odoo-community.org/projects/server-env-16-0/server-env-16-0-server_environment_ir_config_parameter/es/
Currently translated at 100.0% (4 of 4 strings)

Translation: server-env-17.0/server-env-17.0-server_environment_ir_config_parameter
Translate-URL: https://translation.odoo-community.org/projects/server-env-17-0/server-env-17-0-server_environment_ir_config_parameter/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-env-18.0/server-env-18.0-server_environment_ir_config_parameter
Translate-URL: https://translation.odoo-community.org/projects/server-env-18-0/server-env-18-0-server_environment_ir_config_parameter/
@OCA-git-bot OCA-git-bot added series:20.0 mod:server_environment_ir_config_parameter Module server_environment_ir_config_parameter labels Oct 5, 2026
@rven rven mentioned this pull request Oct 5, 2026
3 tasks
@rven

rven commented Oct 5, 2026

Copy link
Copy Markdown
Contributor Author

@legalsylvain why did you close this PR?

@legalsylvain

Copy link
Copy Markdown
Contributor

not respecting OCA rules !

@rven

rven commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor Author

What are the not respected OCA Rules?
A little bit more context would be helpful.

Maybe related to this?

  • Critical rules:
    • every AI-assisted commit gets an Assisted-by: trailer, never Co-authored-by:
    • the PR description shows the same disclosure
    • the policy's red lines (more than 5 PRs in 24 hours, over 500 lines without maintainer agreement, regenerating instead of answering review)
    • never draft the user's replies to reviewers
  • Both checkpoints before acting: the first one now presents announcing on the migration issue as the prior maintainer agreement a 500+ line [MIG] PR needs. Both checkpoints show your OCA PR count for the last 24 hours, and at 4 or more the skill recommends stopping.
  • [MIG] commit gets the trailer, for example Assisted-by: Claude Opus 5.5.
  • the description ends with the same Assisted-by: line instead of my earlier wording.
  • too many AI-assisted PRs in one day get closed, with today's [20.0][MIG] server_environment_ir_config_parameter: Migration to 20.0 #308 as the example.

@rven

rven commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor Author

@legalsylvain Can you open the PR again please?
I also made the required changes to be in line with the OCA policies.
The migrated module is working fine, it has been tested already and we are using it as is in our new projects.

@legalsylvain legalsylvain reopened this Oct 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mod:server_environment_ir_config_parameter Module server_environment_ir_config_parameter series:20.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.