Repository navigation
[FIX] data_encryption: pin cryptography to odoo core version - #304
Merged
Merged
Conversation
Contributor
Author
|
@florian-dacosta can you pls have a look at this? Builds on 18.0 are broken ATM. |
An unpinned "cryptography" in requirements.txt lets pip resolve the
latest release, which removed the private
cryptography.hazmat.backends.openssl.x509 module. Odoo's own pinned
urllib3==1.26.5 (Python < 3.12) still imports that module through its
legacy contrib.pyopenssl shim, used unconditionally by
odoo/addons/base/models/ir_mail_server.py, so any install that
upgrades cryptography past that point fails to boot at all:
ModuleNotFoundError: No module named
'cryptography.hazmat.backends.openssl.x509'
Cap it below the breaking release so the version Odoo itself pins
(3.4.8 on Python < 3.12, 42.0.8 on Python >= 3.12) is still installable.
simahawk
force-pushed
the
18-fix-data-enc-pin
branch
from
September 28, 2026 15:29
4aca3c8 to
4f7cc72
Compare
simahawk
changed the title
florian-dacosta
approved these changes
Sep 29, 2026
|
/ocabot merge patch |
Contributor
|
Sorry @florian-dacosta you are not allowed to merge. To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons. If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the |
Contributor
Author
|
/ocabot merge patch |
Contributor
|
This PR looks fantastic, let's merge it! |
Contributor
|
Congratulations, your PR was merged at 07fe358. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…eakage
An unpinned "cryptography" in requirements.txt lets pip resolve the latest release, which removed the private
cryptography.hazmat.backends.openssl.x509 module. Odoo's own pinned urllib3==1.26.5 (Python < 3.12) still imports that module through its legacy contrib.pyopenssl shim, used unconditionally by odoo/addons/base/models/ir_mail_server.py, so any install that upgrades cryptography past that point fails to boot at all:
Cap it below the breaking release so the version Odoo itself pins (3.4.8 on Python < 3.12, 42.0.8 on Python >= 3.12) is still installable.