[18.0][MIG] crm_reminder_email_activities: Migration to 18.0 by anusriNPS · Pull Request #756 · OCA/crm

anusriNPS · 2026-07-21T07:04:37Z

Migrating below PR which contains unmerged module crm_reminder_email_activities from 16.0 to 18.0

Related 16.0 PR: #753

anusriNPS · 2026-07-21T11:23:11Z

HekkiMelody

Code and functional review, LGTM

Module was originally proposed for v16 here: #753

SirPyTech

Thanks for the PR!
This is good, I suggested some improvements but nothing worth blocking from merge in my opinion.

SirPyTech · 2026-08-25T08:46:02Z

+        <field name="interval_type">weeks</field>
+        <field
+            name="nextcall"
+            eval="(DateTime.today() + relativedelta(weekday=6)).strftime('%Y-%m-%d')"


suggestion: strftime might not be needed.

Moreover, why postponing the first call?

The idea is to send the reminder on a Sunday, containing the activities for the coming week.

nextcall field being a datetime type removed using strftime as datetime object is accepted by field

SirPyTech · 2026-08-25T08:49:20Z

+    _inherit = "res.users"
+
+    @api.model
+    def cron_send_crm_reminder_activities(self):


suggestion: Please consider moving these methods to crm.lead: if everyone did this, the res.users model would be full of methods for every kind of model.

Using crm.lead model as suggested

SirPyTech · 2026-08-25T08:52:51Z

+    @api.model
+    def cron_send_crm_reminder_activities(self):
+        users = self._get_crm_activities().mapped("user_id")
+        mail_template = self.env.ref(


suggestion: Please handle the case where the template does not exist, this might be a good opportunity to add a test for this piece of code.

Updated handling of case without template and added testcase as suggested

SirPyTech · 2026-08-25T08:53:53Z

+        for user in users:
+            mail_template.send_mail(user.id)
+
+    def _get_crm_activities(self, user=None):


suggestion: Please consider using self for the user, instead of user since we are in the res.users model.

As 'crm.lead' model is used, changes are taken care accordingly

SirPyTech · 2026-08-25T09:00:28Z

+from odoo.tests.common import TransactionCase, new_test_user
+
+
+class TestEmailReminderPlannedActivity(TransactionCase):


suggestion: We could use BaseCommon to reduce the mail logs as suggested in https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-18.0:

evaluate the use of BaseCommon as base test class if you need to setup company, currency, users and groups in a special way)

Inherited from Basecommon and included tracking_disable to env context

SirPyTech · 2026-08-25T09:04:11Z

note: Please clarify in the PR description that this is porting an unmerged module: from the point of view of the reviewer this changes the approach.
When reviewing a migration of a merged module the reviewer just has to check that the module is correctly adapted to the target version; if the module was never merged, it has to be reviewed in full like a brand new module.

Agree, PR related information and unmerged related comments are updated

SirPyTech · 2026-08-25T09:23:38Z

+                                    t-value="object.env[activity.res_model].browse(activity.res_id)"
+                                />
+                                <p style="margin-bottom: 5px">Deadline:
+                                    <span t-out="activity.date_deadline" />


suggestion: Consider formatting this date in the user's locale, it might suffice using t-field instead of t-out.

Using t-field as suggested

…ties that are due

Using "crm.lead" as model instead of "res.users" and modified module accordingly.Introduced testcase to verify sending of mail for crm activities when related mail template is not available.

anusriNPS · 2026-09-30T07:02:32Z

Verified with latest update on using crm.lead model:

OCA-git-bot added series:18.0 mod:crm_reminder_email_activities Module crm_reminder_email_activities labels Jul 21, 2026

anusriNPS force-pushed the 18.0-mig-crm_reminder_email_activities branch from e497f5e to 0704efa Compare July 21, 2026 11:16

anusriNPS changed the title ~~[18.0][MIIG] crm_reminder_email_activities: Migration to 18.0~~ [18.0][MIG] crm_reminder_email_activities: Migration to 18.0 Jul 21, 2026

HekkiMelody approved these changes Jul 22, 2026

View reviewed changes

BhaveshHeliconia approved these changes Aug 19, 2026

View reviewed changes

OCA-git-bot added the approved label Aug 19, 2026

SirPyTech approved these changes Aug 25, 2026

View reviewed changes

alessandropecchini99 and others added 2 commits September 29, 2026 07:58

[ADD] crm_reminder_email_activities: send email reminder about activi…

5700fd0

…ties that are due

[IMP] crm_reminder_email_activities: pre-commit auto fixes

bf0cf2e

anusriNPS force-pushed the 18.0-mig-crm_reminder_email_activities branch from 0704efa to 20bfb76 Compare September 29, 2026 06:37

anusriNPS marked this pull request as draft September 29, 2026 07:40

anusriNPS added 2 commits September 29, 2026 11:19

[MIG] crm_reminder_email_activities: Migration to 18.0

7ab06c9

[IMP] crm_reminder_activities: Updated model, job and testcase

bff303c

Using "crm.lead" as model instead of "res.users" and modified module accordingly.Introduced testcase to verify sending of mail for crm activities when related mail template is not available.

anusriNPS force-pushed the 18.0-mig-crm_reminder_email_activities branch from 20bfb76 to bff303c Compare September 30, 2026 07:01

anusriNPS marked this pull request as ready for review September 30, 2026 07:01

		from odoo.tests.common import TransactionCase, new_test_user


		class TestEmailReminderPlannedActivity(TransactionCase):

Uh oh!

Conversation

anusriNPS commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

anusriNPS commented Jul 21, 2026

Uh oh!

HekkiMelody left a comment

Choose a reason for hiding this comment

Uh oh!

SirPyTech left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anusriNPS commented Sep 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

anusriNPS commented Jul 21, 2026 •

edited

Loading