[19.0][FIX] loyalty: incomplete migration#5673
Conversation
OCA-git-bot
added
mod:openupgrade_scripts
hbrunn
changed the title
|
/ocabot migration loyalty Depends on :
|
… card templates On top of OCA#5673: the standard gift_card/loyalty_card templates are reset by the non-noupdate module update, but custom loyalty.card templates referencing the removed object._get_mail_partner() helper are not, and the 19.0 data-load render aborts on the missing method before post-migration runs. Rewrite the helper back to its exact 18.0 equivalent (object.partner_id, the recipient) across every stored template field (lang/partner_to/email_to/body_html) of model loyalty.card. fix_template_lang runs first so the standard templates' lang is already NULL and untouched here.
|
@hbrunn is this out of scope like the backfill on dates since would hit a copy only? hbrunn/OpenUpgrade@19.0-fix-crm...ledoent:OpenUpgrade:19.0-fix-loyalty-suggestion |
|
it's not out of scope, the replacement should however be People with custom reports will have to fix them themselves. You can propose your fix after this one is merged, which will be faster if you actually take part in the review process. |
@dnplkndll You can proceed now to propose new fixes. |
|
But if this is incomplete, it shouldn't put |
6 participants
previous attempt was incomplete and wrong