types and docs for integrations_dir#555
Open
anthraxx wants to merge 3 commits into
Open
Conversation
When using custom integrations loaded from the new integrations_dir opt, it produces type/linter errors, as the used custom integrations are not part of the enum values. Allow strings as well for the type, which is the sweat spot by allowing for type based completions when defining the upstream integrations, but also allow custom integrations without linter type errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix integrations type to account for integrations_dir functionality and extend docs explaining the new feature.
When using custom integrations loaded from the new integrations_dir
opt, it produces type/linter errors, as the used custom integrations are
not part of the enum values. Allow strings as well for the type, which
is the sweat spot by allowing for type based completions when defining
the upstream integrations, but also allow custom integrations without
linter type errors.