Repository navigation
Show the site-wide banner at the top of the docs - #302
Merged
Merged
Conversation
The landing banner is now shared: Banner.astro moves to components/ui and reads a top-level `banner` config entry used by both the landing and the docs, so the text and link are updated in one place. Positioning is left to the parent: the landing keeps it sticky, and the docs render it inside Starlight's fixed header. Starlight offsets the sidebar, main frame, mobile TOC, right sidebar and scroll padding from --sl-nav-height, so the docs reserve room for the banner by adding --hh-docs-banner-height to that variable. Only the site title logo and the mobile menu button, which center themselves within the header height, subtract it again. The docs don't load the landing fonts, so the banner falls back to Starlight's monospace stack there. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
alcuadrado
approved these changes
Sep 9, 2026
alcuadrado
approved these changes
Sep 9, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #301 (banner text/link update). Retarget to
mainonce that merges.What
Adds the same top banner the landing page has to every docs page, above the Starlight header.
Banner.astromoves tosrc/components/ui/and reads a new top-levelbannerentry insrc/config.ts, used by both the landing and the docs. Positioning is left to the parent: the landing keeps it sticky, the docs render it inside Starlight's fixed header.--sl-nav-height. The custom theme CSS adds--hh-docs-banner-height(40px) to that variable, so everything clears the banner with no per-component changes. Only the site title logo and the mobile menu button, which center themselves within the header height, subtract it again.Testing
Measured and screenshotted at 375, 768, 1200 and 1440px in light and dark: banner at 0–40px, header grown by exactly 40, logo at its original size, menu button centered in the nav strip, sidebar pane and mobile TOC starting at the header's bottom edge, mobile menu opening below the header, anchor links landing with the same clearance as before, landing banner still sticky.
astro check, spellcheck, tests and prettier pass.🤖 Generated with Claude Code