Skip to content

mailspring: electron_41 -> electron_43 - #555732

Merged
SuperSandro2000 merged 1 commit into
NixOS:masterfrom
wrench-exile-legacy:mailspring/electron-43
Aug 23, 2026
Merged

mailspring: electron_41 -> electron_43#555732
SuperSandro2000 merged 1 commit into
NixOS:masterfrom
wrench-exile-legacy:mailspring/electron-43

Conversation

@wrench-exile-legacy

@wrench-exile-legacy wrench-exile-legacy commented Aug 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

See #555100

Updates electron from 41.7.2 -> 43.4.1, due to electron 41 end of life.
I had to update node-abi to allow node-gyp to recognise the newer electron version, and update better-sqlite3 which has support for the newer javascript engine in newer versions of electron.

To reproduce the lock file, changeelectron to 43.4.1, and run the following:

  npm update better-sqlite3 node-abi
  cd app/
  npm update better-sqlite3 node-abi

I will also attempt to submit an upstream PR.

Things done

@nixpkgs-ci nixpkgs-ci Bot added 8.has: package (update) This PR updates a package to a newer version 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Aug 23, 2026
@nixpkgs-review-gha

nixpkgs-review-gha commented Aug 23, 2026

Copy link
Copy Markdown

✅ nixpkgs-review result

Generated using nixpkgs-review-gha (b0ab82d)

Command: nixpkgs-review pr 555732
Commit: d2552b6d459192ec575ae6ed45ea39da888f111d (subsequent changes)
Merge: b3d50ad1b73123cc8e49e994cfe266048d76d985

Triggered by @wrench-exile-legacy (280737824)
Logs: https://github.com/wrench-exile-legacy/nixpkgs-review-gha/actions/runs/32640606330/attempts/1

x86_64-linux

✅ 1 package built:
  • mailspring

aarch64-linux

✅ 1 package built:
  • mailspring

aarch64-darwin (sandbox = relaxed)

✅ 1 package built:
  • mailspring

@wrench-exile-legacy

wrench-exile-legacy commented Aug 23, 2026

Copy link
Copy Markdown
Contributor Author

Upstream PR Foundry376/Mailspring#2818

SuperSandro2000
SuperSandro2000 reviewed Aug 23, 2026
View reviewed changes
Comment thread pkgs/by-name/ma/mailspring/package.nix

patches = [
./remove-rpm-deb-and-macos-package-generation.patch
./update-electron-from-41.7.2-43.4.1.patch

@SuperSandro2000 SuperSandro2000 Aug 23, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably cannot fetchpatch it, but nice that it is merged upstream

@SuperSandroBot

SuperSandroBot commented Aug 23, 2026

Copy link
Copy Markdown

✅ nixpkgs-review result

Generated using nixpkgs-review-gha (b0ab82d)

Command: nixpkgs-review pr 555732
Commit: d2552b6d459192ec575ae6ed45ea39da888f111d (subsequent changes)
Merge: b3d50ad1b73123cc8e49e994cfe266048d76d985

Logs: https://github.com/SuperSandro2000/nixpkgs-review-gha/actions/runs/32661214549/attempts/1

x86_64-linux

✅ 1 package built:
  • mailspring

aarch64-linux

✅ 1 package built:
  • mailspring

aarch64-darwin (sandbox = relaxed)

✅ 1 package built:
  • mailspring

@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 1 This PR was reviewed and approved by one person. 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Aug 23, 2026
@SuperSandro2000
SuperSandro2000 added this pull request to the merge queue Aug 23, 2026
Merged via the queue into NixOS:master with commit d6d1556 Aug 23, 2026
41 checks passed
@wrench-exile-legacy
wrench-exile-legacy deleted the mailspring/electron-43 branch August 24, 2026 10:59
@teutat3s teutat3s mentioned this pull request Aug 24, 2026
Open
51 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

Assignees

No one assigned

Labels

2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". 8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wrench-exile-legacy @nixpkgs-review-gha @SuperSandroBot @SuperSandro2000