close-active-view invoked with a keybinding crashes Nev with SIGSEGV

[moigagoo]

Here's my keybindings.json:

{
    "vim.normal": {
        "J": ["open-next-view", "**"],
        "K": ["open-prev-view", "**"],
        "D": ["close-active-view"],
        "F": [".format"],
    },
    "vim.insert": {
        "jj": ["set-mode", "vim.normal"]
    },
    "vim.completion": {
        "<DOWN>": ["select-prev-completion"],
        "<UP>": ["select-next-completion"]
    }
}

When I press D in normal mode, the editor crashes with SIGSEGV: Attempt to read from nil? and then stdout gets spammed with and endless stream:

Environment

WSL on Windows 11.

[Nimaoth]

I'll fix the crash, but for now you can define the close-active-view keybinding in the editor or vim.base category instead of vim.normal. Although then you won't be able to use D because that already exists in vim.normal which has higher priority than vim.base or editor (basically the priority list is vim.normal > vim > vim.base > editor).

{
    "editor": {
        "D": ["close-active-view"],
    },
    "vim.base": { // or this
        "D": ["close-active-view"],
    }
}

Basically keybindings in editor or vim.base get executed in a global context, and keybindings in vim or vim.normal get executed in the context of the active editor. But close-active-view closes the editor while it's still used by the command, so using the global context prevents the crash

The spamming in the console probably happens because some terminal properties don't get reset when it crashes

[moigagoo]

@Nimaoth I tried putting this keybinding in editor and vim.base but as you already said they don't work.

So, I guess there is no way to set D as a keybinding for now?

[Nimaoth]

You can override D in vim.normal if you want, you just can't use close-active-view or any other command that closes the active editor in e.g. vim.normal.
If you want to override D in e.g. vim.base the you would have to remove the D mapping from config/keybindings.json (next to the executable) in the vim.normal section.

[Nimaoth]

If you build nev yourself I just pushed a fix for the crash on release-0.5 which should make your keybindings work (so overriding D in vim.normal with close-active-view)

[moigagoo]

@Nimaoth unfortunately, so far I could not build Nev from source, compilation fails on zig treesitter:

build language zig
Setting up Git repo: https://github.com/maxxnino/tree-sitter-zig
Pulling repository
Command failed: 1
git pull --depth=1 origin master
fatal: couldn't find remote ref master

stack trace: (most recent call last)
nimtreesitter.nimble(23, 1)
nimtreesitter.nimble(21, 7) setupTask
nimscript.nim(264, 7)    exec
/home/moigagoo/.nimble/pkgs2/nim-2.2.8-46b3923a8c0a031bfe29df5c5903c8c4898d338f/lib/system/nimscript.nim(264, 7) Error: unhandled exception: FAILED: nimgen treesitter_zig.cfg [OSError]
[Error]  (nimtreesitter.Nimaoth.github.com) Nimscript failed: nim e --hints:off -d:atlas atlas_build_1.nims

It seems like branch name master is hardcoded somewhere but this repo uses something else (e.g. main).

Anyway, so far I've set the shortcut to Alt+d, which is good enough for the meantime before the new version is released.