Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions MANIFEST.in
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
include README.rst
include LICENSE.txt
include NOTICE.txt
include README.md
include LICENSE

include moabb/datasets/summary_*.csv

Expand Down
4 changes: 2 additions & 2 deletions docs/prepare_paper_results_tables.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@
"EEGTCNet": "Keras_EEGITNet.yml",
"FilterBank+SVM": "FBCSP.py",
"FgMDM": "FgMDM.yml",
"LogVariance+LDA": "LogVar_grid.yml",
"LogVariance+SVM": "LogVar_grid.yml#L7",
"LogVariance+LDA": "LogVar.yml",
"LogVariance+SVM": "LogVar_grid.yml",
"MDM": "MDM.yml",
"ShallowConvNet": "Keras_ShallowConvNet.yml",
"TRCSP+LDA": "WTRCSP.py",
Expand Down
2 changes: 2 additions & 0 deletions docs/source/whats_new.rst
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ Requirements

Bugs
~~~~
- Fix the ``LogVariance+LDA`` row of the benchmark results page (:doc:`paper_results`) linking to ``pipelines/LogVar_grid.yml``, which is the ``Log Variance SVM grid`` pipeline and classifies with ``SVC``. It now links to ``pipelines/LogVar.yml``, the ``Log Variance LDA`` pipeline the row reports. The ``LogVariance+SVM`` row keeps ``LogVar_grid.yml`` and loses its ``#L7`` fragment, which highlighted the shared ``LogVariance`` step rather than the ``SVC`` one (by `Bhargav Kowshik`_).
- Fix :class:`moabb.datasets.BNCI2022_001` epoching its instantaneous waypoint markers as 90-second trials: only ``trajectory_start`` is a trial event now (32 bounded, non-overlapping 90 s epochs per subject), and the loader annotates each trigger pulse once (rising edge) instead of once per held sample, which had inflated subject 1 to 33,114 annotations and a 364 GiB allocation. Waypoint and trajectory-end markers stay available as annotations on the loaded raws (:gh:`1143` by `Bruno Aristimunha`_)
- Retag :class:`moabb.datasets.Kaneshiro2015` from ``p300`` to ``imagery`` so its declared default paradigm accepts it: its six visual object categories carry no Target/NonTarget pair, so the P300 paradigm rejected every subject. The catalog row and documentation grouping move with it (:gh:`1143` by `Bruno Aristimunha`_)
- Allow :class:`moabb.paradigms.RestingStateToP300Adapter` to be constructed with defaults: ``events=None`` now means all of the dataset's events, matching how every in-repo usage builds it (:gh:`1143` by `Bruno Aristimunha`_)
Expand Down Expand Up @@ -104,6 +105,7 @@ Bugs

Code health
~~~~~~~~~~~
- Point ``MANIFEST.in`` at the files the repository actually ships. Three of its six directives named ``README.rst``, ``LICENSE.txt`` and ``NOTICE.txt``; the repository has ``README.md`` and ``LICENSE``, and no notice file at all, so every ``python -m build --sdist`` printed three ``warning: no files found matching ...`` lines. The sdist contents are unchanged -- setuptools already picked up the readme and the license through ``project.readme`` and its default ``license-files`` -- only the warnings go away (by `Bhargav Kowshik`_).
- Bump the ``ruff-pre-commit`` hook from ``v0.15.9`` to ``v0.15.20`` (quarterly ``pre-commit.ci`` autoupdate). The bump is lint-neutral on the current tree: ``ruff check`` and ``ruff format --check`` return identical results at both pins across all 229 tracked ``*.py`` / ``*.pyi`` files, and ``pre-commit run --all-files`` rewrites no file (:gh:`1119` by `pre-commit-ci`_).
- Fix deprecated ``pyriemann.utils.{mean,covariance,base}`` import paths: bump the minimum ``pyriemann`` to ``0.12`` and update all import sites in ``moabb/pipelines/csp.py``, ``moabb/pipelines/classification.py``, ``moabb/datasets/preprocessing.py``, and the Riemannian artifact rejection example to use ``pyriemann.geometry.*`` (introduced in pyriemann 0.12, removal of the old paths scheduled for 0.14), and import ``Potato``/``PotatoField`` from ``pyriemann.artifact_detection`` (moved from ``pyriemann.clustering`` in 0.12) (by `copilot-swe-agent`_).
- Install CPU-only PyTorch wheels in CI by setting ``UV_TORCH_BACKEND=cpu`` in the test, braindecode, and docs workflows, so runners no longer download multi-GB CUDA builds of ``torch`` (pulled transitively via the ``deeplearning`` extra / braindecode) (:gh:`1083` by `Bhargav Kowshik`_).
Expand Down
Loading