Fix stale MANIFEST.in filenames and the LogVariance+LDA pipeline link - #1150
Merged
bruAristimunha merged 3 commits intoAug 21, 2026
Merged
Conversation
Three of the six directives named README.rst, LICENSE.txt and NOTICE.txt.
The repository ships README.md and LICENSE, and no notice file at all, so
`python -m build --sdist` printed on every build:
warning: no files found matching 'README.rst'
warning: no files found matching 'LICENSE.txt'
warning: no files found matching 'NOTICE.txt'
Rename the two that have a counterpart in the tree and drop the third.
The sdist contents do not change: setuptools already included the readme
through project.readme and LICENSE through its default license-files
patterns. Verified by building the sdist before and after -- identical
216-entry file list, three fewer warnings.
prepare_paper_results_tables.py mapped LogVariance+LDA to LogVar_grid.yml, which is `name: Log Variance SVM grid` and classifies with SVC; the next line mapped LogVariance+SVM to that same file. The LDA row corresponds to LogVar.yml (`name: Log Variance LDA`). Point it there, and drop the #L7 fragment from the SVM entry: line 7 is the shared LogVariance step, not the SVC one, so the anchor highlights the wrong part of the file. Regenerating the tables from results/ changes exactly those two links.
Signed-off-by: Bru <b.aristimunha@gmail.com>
Collaborator
|
thanks @bkowshik 🙏🏽 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small independent fixes; no change to library behaviour.
MANIFEST.inThree of its six directives named files that don't exist —
README.rst,LICENSE.txt,NOTICE.txt— so everypython -m build --sdistprinted threewarning: no files found matching ...lines. The repo shipsREADME.mdandLICENSE, and no notice file at all.The sdist contents don't change: setuptools already included the readme via
project.readmeandLICENSEvia its defaultlicense-files. Verified by building the sdist before and after — identical 216-entry file list, three fewer warnings.docs/prepare_paper_results_tables.pyLogVariance+LDAlinked topipelines/LogVar_grid.yml, which isname: Log Variance SVM gridand classifies withSVC; the next line mapsLogVariance+SVMto that same file. The LDA row now links topipelines/LogVar.yml(name: Log Variance LDA).The
#L7fragment on the SVM entry is dropped — line 7 is the sharedLogVariancestep, not theSVCone. Regenerating the tables fromresults/changes exactly those two links and nothing else.Changelog entries added under Code health and Bugs.