Repository navigation
runner: Run the guest on the standard configuration, with no openvm.toml - #6
Closed
maximmenshikov wants to merge 2 commits into
Closed
maximmenshikov wants to merge 2 commits into
maximmenshikov wants to merge 2 commits into
Conversation
The configuration in openvm.toml was SdkVmConfig::standard() of the SDK, which is also what ere uses. The runner now makes it from SdkVmConfig::standard() and the parameters of AppConfig by default, and takes only the ELF and the input. A guest of bflat --libc openvm then needs no file next to the ELF. The jobs that run the published image give it "-", the standard configuration that the image ships, until the next image is released. Signed-off-by: Maxim Menshikov <maksim.menshikov@nethermind.io>
The published image takes the path of a configuration file, and the runner no longer has one. The job of the division hint builds the image of this commit; it now saves it as an artifact, and the u256 and secp256k1 jobs load it and run the guests with no configuration. Signed-off-by: Maxim Menshikov <maksim.menshikov@nethermind.io>
Collaborator
Author
|
Moved to #5 (manifest-schema-2), so that the refactor, the signing and the runner are tested together. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The runner makes the VM configuration from
SdkVmConfig::standard()and takes noopenvm.toml:runner/openvm.tomlwasSdkVmConfig::standard(): the same moduli, fp2, curves and pairing, in the same order (compared withopenvm_standard.tomlof the SDK atOPENVM_REV). ere also runs OpenVM guests onSdkVmConfig::standard()with no file. A guest ofbflat --libc openvmthen needs nothing next to its ELF. The system parameters are the default ofAppConfig(app_params_with_100_bits_security(MAX_APP_LOG_STACKED_HEIGHT)), as a toml with nosystem_paramsgave.runner/openvm.tomlis removed, and the image no longer ships/openvm.toml.Note for ere: the division hint (
zkvm_u512_divrem_hint, phantom imm0x4d1) is registered only by this runner. On the standard executor of ere it transpiles tounimp, so a guest that calls it traps there.Testing: not built locally. CI builds the image from
runner/and runs the division-hint, u256 and secp256k1 guests on it.🤖 Generated with Claude Code