Repository navigation
Conversation
The python-tests job installs ruff unpinned (ruff>=0.5, no uv.lock), so it now resolves to ruff 0.16.x, which enables ISC004 (unparenthesized implicit string concatenation inside a collection) under the already-selected ISC group. The four existing hits in v7/dashboard.py and tb/cosim/compare_doppler.py fail "uv run ruff check ." and turn the Python Lint + Tests job red for every PR against develop. Wrap each multi-line f-string concatenation in parentheses. The resulting strings are byte-for-byte identical; this only makes the concatenation explicit. Signed-off-by: FenjuFu <fufenjupku@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #194
What
Parenthesize the four implicit multi-line f-string concatenations that ruff >= 0.16 reports as ISC004:
9_Firmware/9_3_GUI/v7/dashboard.py(status readback lines, x2)9_Firmware/9_2_FPGA/tb/cosim/compare_doppler.py(check labels, x2)Why
CI installs ruff unpinned (
ruff>=0.5, no lock), so it now gets 0.16.x. These four hits turn the Python Lint + Tests job red for every PR againstdevelop(see #185 / #184 / #183).Behaviour
None. The concatenated strings are identical; the parentheses just make the concatenation explicit.
Verification
uv run --with ruff==0.16.3 ruff check .(the version CI resolves):All checks passed!(before: 4 × ISC004)py_compileof both files OKgit diff --checkclean