Skip to content

Pin CMake to < 4.4#3080

Open
KyleFromNVIDIA wants to merge 1 commit into
NVIDIA:mainfrom
KyleFromNVIDIA:cmake-pin
Open

Pin CMake to < 4.4#3080
KyleFromNVIDIA wants to merge 1 commit into
NVIDIA:mainfrom
KyleFromNVIDIA:cmake-pin

Conversation

@KyleFromNVIDIA

Copy link
Copy Markdown
Member

Description

rapids-cmake is currently broken by CMake 4.4, so pin CMake until we have a fix.

Issue: rapidsai/build-planning#302

@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: e8c3faf6-9613-46c6-ad3b-ba6e29c6bd6f

📥 Commits

Reviewing files that changed from the base of the PR and between 99ca825 and 2cc13e1.

📒 Files selected for processing (11)
  • conda/environments/all_cuda-129_arch-aarch64.yaml
  • conda/environments/all_cuda-129_arch-x86_64.yaml
  • conda/environments/all_cuda-133_arch-aarch64.yaml
  • conda/environments/all_cuda-133_arch-x86_64.yaml
  • conda/recipes/libraft/conda_build_config.yaml
  • conda/recipes/pylibraft/conda_build_config.yaml
  • conda/recipes/raft-dask/conda_build_config.yaml
  • dependencies.yaml
  • python/libraft/pyproject.toml
  • python/pylibraft/pyproject.toml
  • python/raft-dask/pyproject.toml

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Constrained supported CMake versions to >=4.0,<4.4 across build environments and packaging configurations.
    • Updated the copyright header in the raft-dask package to cover 2022–2026.

Walkthrough

Changes

CMake version bounds

Layer / File(s) Summary
Shared build constraints
dependencies.yaml, conda/recipes/*/conda_build_config.yaml
Shared and Conda recipe CMake requirements now use >=4.0,<4.4.
Conda environment constraints
conda/environments/all_cuda-129_*.yaml, conda/environments/all_cuda-133_*.yaml
CUDA 12.9 and 13.3 environment definitions add the <4.4 CMake upper bound for both architectures.
Python build constraints
python/*/pyproject.toml
Python build requirements now use cmake>=4.0,<4.4; raft-dask also updates its SPDX year range.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested labels: improvement, non-breaking

Suggested reviewers: bdice

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely states the main change: pinning CMake below 4.4.
Description check ✅ Passed The description matches the change set and explains why CMake is being pinned.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@KyleFromNVIDIA KyleFromNVIDIA added bug Something isn't working non-breaking Non-breaking change labels Jul 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant