-
Notifications
You must be signed in to change notification settings - Fork 795
Aero recipe: document sampled forces and preserve exported quadrature #1971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
peterdsharpe
wants to merge
13
commits into
NVIDIA:main
Choose a base branch
from
peterdsharpe:pr/recipe-ht-forces
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,160
−247
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
1c87ed1
Carry the quadrature measure onto cell-centroid query points
peterdsharpe e39cd39
Aero recipe: describe subsampled-surface forces as unbiased estimates…
peterdsharpe 31e92af
Merge commit '1f7887a2fb51f19ed4233e63cfc6cae451f648d5' into codex/au…
peterdsharpe a71c242
Clarify sampling and reference-frame limits of force estimates
peterdsharpe 715ef3e
Merge upstream main and resolve changelog conflict for #1970
peterdsharpe 22219d4
Merge upstream main and resolve changelog conflict for #1971
peterdsharpe 69b20ec
Merge branch 'main' into pr/query-point-measure
peterdsharpe ba52e83
Merge upstream main into pr/query-point-measure
peterdsharpe 646aafc
Unify complete integration measures across cells and point samples
peterdsharpe 241a3e9
Keep GLOBE dataset measure tests with the GLOBE suite
peterdsharpe fc52b33
Merge unified measures into aero force documentation and export tests
peterdsharpe e2ff581
Tighten mesh calculus documentation and clarify released migration
peterdsharpe f4475b3
Merge updated #1970 documentation into sampled-force branch
peterdsharpe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The visualization path subsamples
prediction_meshand stores the represented-area correction incell_data["_effective_measure"]. Postprocessing then rebuildspred_surfacewith empty cell data, andcompute_surface_force_coefficientsweights forces using geometriccell_areas. This discards the correction, so the reported predicted Cd/Cl/Cs shrink with the retained surface fraction. Preserve the effective measure onpred_surfaceand usecell_measures(surface_mesh)for integration.