[CUB] warpspeed kernel: make scan_resources_t copy#9751
Conversation
Performance ReportB200deterministic — main → warpspeed_ker_scan_res_copy (avg %Diff: -0.05%)lookahead — main → warpspeed_ker_scan_res_copy (avg %Diff: -0.09%)sum — main → warpspeed_ker_scan_res_copy (avg %Diff: +0.03%) |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe ChangesScan closure resource ownership
critical: This changes res from a reference to a value copy, meaning the closure now operates on a separate copy of scan_resources_t instead of the shared instance. If scan_resources_t holds mutable state (e.g., counters, tile status) meant to be shared/mutated across the squad, this silently breaks that sharing — dispatch_squad and other closures using the original res object will no longer see updates made through this closure's copy. Verify scan_resources_t is trivially copyable and that no shared mutable state is lost; otherwise revert to reference semantics. Comment |
🥳 CI Workflow Results🟩 Finished in 2h 36m: Pass: 100%/287 | Total: 11d 17h | Max: 2h 34m | Hits: 20%/955032See results here. |
Description
closes
This improves performance of warpspeed on sm90 using atomics (#9565).
It doesn't impact performance on current implementation for SM100+ .
Further it reduces SASS on
Checklist