Deprecate cub::ChainedPolicy#9744
Merged
Merged
Conversation
17 tasks
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (34)
✅ Files skipped from review due to trivial changes (7)
🚧 Files skipped from review as they are similar to previous changes (27)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis PR renames the internal chained-policy implementation to ChangesChainedPolicy to detail::chained_policy migration
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
cub/cub/util_device.cuh (1)
788-790: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valuesuggestion: Stale comment—references old
ChainedPolicyname and a nonexistentfind_and_invoke_policycall site wording. Update to match the rename.template <int, typename, typename> - friend struct chained_policy; // let us call find_and_invoke_policy of other ChainedPolicy instantiations + friend struct chained_policy; // let us call find_and_invoke_policy of other chained_policy instantiations
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: c702c4ea-7371-4e9a-9edb-feca0a05ac43
📒 Files selected for processing (34)
cub/cub/device/dispatch/tuning/tuning_adjacent_difference.cuhcub/cub/device/dispatch/tuning/tuning_for.cuhcub/cub/device/dispatch/tuning/tuning_histogram.cuhcub/cub/device/dispatch/tuning/tuning_merge_sort.cuhcub/cub/device/dispatch/tuning/tuning_radix_sort.cuhcub/cub/device/dispatch/tuning/tuning_reduce.cuhcub/cub/device/dispatch/tuning/tuning_reduce_by_key.cuhcub/cub/device/dispatch/tuning/tuning_rle_encode.cuhcub/cub/device/dispatch/tuning/tuning_rle_non_trivial_runs.cuhcub/cub/device/dispatch/tuning/tuning_scan.cuhcub/cub/device/dispatch/tuning/tuning_scan_by_key.cuhcub/cub/device/dispatch/tuning/tuning_segmented_reduce.cuhcub/cub/device/dispatch/tuning/tuning_segmented_sort.cuhcub/cub/device/dispatch/tuning/tuning_select_if.cuhcub/cub/device/dispatch/tuning/tuning_three_way_partition.cuhcub/cub/device/dispatch/tuning/tuning_unique_by_key.cuhcub/cub/util_device.cuhcub/test/catch2_test_device_adjacent_difference_custom_policy_hub.cucub/test/catch2_test_device_histogram_custom_policy_hub.cucub/test/catch2_test_device_merge_sort_custom_policy_hub.cucub/test/catch2_test_device_radix_sort_custom_policy_hub.cucub/test/catch2_test_device_reduce_by_key_custom_policy_hub.cucub/test/catch2_test_device_reduce_dispatcher.cucub/test/catch2_test_device_rle_custom_policy_hub.cucub/test/catch2_test_device_scan_by_key_custom_policy_hub.cucub/test/catch2_test_device_scan_custom_policy_hub.cucub/test/catch2_test_device_segmented_radix_sort_custom_policy_hub.cucub/test/catch2_test_device_segmented_reduce_custom_policy_hub.cucub/test/catch2_test_device_segmented_sort_custom_policy_hub.cucub/test/catch2_test_device_select_if_custom_policy_hub.cucub/test/catch2_test_device_select_unique_by_key_custom_policy_hub.cucub/test/catch2_test_device_three_way_partition_custom_policy_hub.cucub/test/catch2_test_util_device.cucub/test/catch2_test_vsmem.cu
bernhardmgruber
force-pushed
the
depr_chainedpolicy
branch
from
2838af4 to
9445559
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
🥳 CI Workflow Results🟩 Finished in 3h 08m: Pass: 100%/287 | Total: 12d 10h | Max: 2h 38m | Hits: 18%/1045483See results here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes part of: #9378