Create a swapfile in workflow-run-job-linux#9739
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughAdded Linux CI swap provisioning to the generated ChangesSwap Provisioning in Linux CI Action
Sequence Diagram(s)Not applicable. Suggested labels: ci, infrastructure Suggested reviewers: N/A Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (2)
.github/actions/workflow-run-job-linux/action.yml (2)
117-117: 🩺 Stability & Availability | 🔵 Trivial | ⚡ Quick winsuggestion:
fallocateisn't supported on all filesystems (e.g., some overlay/network filesystems used by CI runners) and fails with "fallocate failed: Operation not supported". Givenset -eis active, this would abort the job outright. Consider falling back toddiffallocatefails.Proposed fallback
- sudo fallocate -l "$((SWAP_SIZE / 1024 / 1024 / 1024))G" /swapfile + sudo fallocate -l "$((SWAP_SIZE / 1024 / 1024 / 1024))G" /swapfile || \ + sudo dd if=/dev/zero of=/swapfile bs=1M count=$((SWAP_SIZE / 1024 / 1024))
116-116: 🎯 Functional Correctness | 🔵 Trivial | 💤 Low valuesuggestion: if
DISK_SIZE / 4rounds down to 0 (very small root disk),fallocate -l 0G /swapfilemay fail or create a useless empty swapfile. Worth a minimum-size floor, though likely low risk on real CI hardware.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 925bb416-855e-4993-85d3-e15c1e66a15e
📒 Files selected for processing (1)
.github/actions/workflow-run-job-linux/action.yml
0ed347e to
9c1e455
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@trxcllnt rebasing over Are the swap files ephemeral to the docker images? Or permanent? If they are ephemeral, perhaps we should consider allocating them directly in the devcontainer builds if that's possible as a longer-term solution. |
|
/ok to test 9e2b7ae |
😬 CI Workflow Results🟥 Finished in 1h 34m: Pass: 99%/506 | Total: 5d 07h | Max: 1h 25m | Hits: 93%/730740See results here. |
Create a swapfile in
workflow-run-job-linuxto work around OOMs during compiling.