Skip to content

Rename cuco .hpp headers to .cuh#9735

Merged
davebayer merged 3 commits into
NVIDIA:mainfrom
PointKernel:cuco-hpp-to-cuh
Jul 8, 2026
Merged

Rename cuco .hpp headers to .cuh#9735
davebayer merged 3 commits into
NVIDIA:mainfrom
PointKernel:cuco-hpp-to-cuh

Conversation

@PointKernel

Copy link
Copy Markdown
Member

Description

Follow-up of #9696.

This PR renames the two remaining .hpp headers in cuda/experimental/__cuco (detail/prime.hpp and detail/utility/traits.hpp) to .cuh, updates their header guards and the two include sites accordingly. All cuco headers now carry the .cuh extension, so the existing cuda/experimental/*.cuh glob in the cudax header test covers them and the dedicated .hpp glob from #9696 is no longer needed. Both headers compile standalone.

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@copy-pr-bot

copy-pr-bot Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@cccl-authenticator-app cccl-authenticator-app Bot moved this from Todo to In Progress in CCCL Jul 7, 2026
@PointKernel PointKernel added cudax Feature intended for the cudax experimental library cuco cuCollections labels Jul 7, 2026
@PointKernel

Copy link
Copy Markdown
Member Author

/ok to test ebfccf2

@github-actions

This comment has been minimized.

@PointKernel

Copy link
Copy Markdown
Member Author

/ok to test c97a6d2

@github-actions

This comment has been minimized.

@PointKernel PointKernel marked this pull request as ready for review July 8, 2026 20:22
@PointKernel PointKernel requested review from a team as code owners July 8, 2026 20:22
@PointKernel PointKernel requested review from andralex July 8, 2026 20:22
@cccl-authenticator-app cccl-authenticator-app Bot moved this from In Progress to In Review in CCCL Jul 8, 2026
@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 2a890280-4a78-43b2-8b48-5254ca45d543

📥 Commits

Reviewing files that changed from the base of the PR and between 69702a9 and c87f42b.

📒 Files selected for processing (4)
  • cudax/include/cuda/experimental/__cuco/capacity.cuh
  • cudax/include/cuda/experimental/__cuco/detail/open_addressing/open_addressing_ref_impl.cuh
  • cudax/include/cuda/experimental/__cuco/detail/prime.cuh
  • cudax/include/cuda/experimental/__cuco/detail/utility/traits.cuh

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated internal header references and guard names for better consistency across CUDA Experimental cuCO components.
    • Standardized include paths used by related low-level utilities.
    • No user-facing APIs or behavior changed.

Walkthrough

Header files under cudax/include/cuda/experimental/__cuco are renamed from .hpp to .cuh naming convention. Include guard macros in prime.cuh and traits.cuh are updated to match, and dependent includes in capacity.cuh and open_addressing_ref_impl.cuh are updated to reference the renamed files.

Changes

cuco header extension rename

Layer / File(s) Summary
Renamed header guards
cudax/include/cuda/experimental/__cuco/detail/prime.cuh, cudax/include/cuda/experimental/__cuco/detail/utility/traits.cuh
Include guard macros and closing #endif comments renamed from _HPP to _CUH suffixes.
Updated includes referencing renamed headers
cudax/include/cuda/experimental/__cuco/capacity.cuh, cudax/include/cuda/experimental/__cuco/detail/open_addressing/open_addressing_ref_impl.cuh
Include directives updated from prime.hpp/traits.hpp to prime.cuh/traits.cuh.

Suggested reviewers: srinivasyadav18, bernhardmgruber

suggestion: confirm the actual files were renamed on disk (hpp→cuh) rather than just guard/include text changes, to avoid dangling old files.


Comment @coderabbitai help to get the list of available commands.

@davebayer davebayer enabled auto-merge (squash) July 8, 2026 20:29
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

🥳 CI Workflow Results

🟩 Finished in 57m 46s: Pass: 100%/55 | Total: 4h 33m | Max: 57m 44s | Hits: 100%/36298

See results here.

@davebayer davebayer merged commit faf5ba4 into NVIDIA:main Jul 8, 2026
75 of 77 checks passed
@github-project-automation github-project-automation Bot moved this from In Review to Done in CCCL Jul 8, 2026
@PointKernel PointKernel deleted the cuco-hpp-to-cuh branch July 8, 2026 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cuco cuCollections cudax Feature intended for the cudax experimental library

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants