-
Notifications
You must be signed in to change notification settings - Fork 425
Integrate Reduce::ByKey to prefetching
#9698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
7b4b610
Add cuda::ptx::prefetch::l1/l2 wrappers for prefetching in libcudacxx
gonidelis 25c153e
Add BLOCK_LOAD_DIRECT_PREFETCH implementation
gonidelis 0494059
integrate reduce_by_key to use load prefetch
gonidelis b3ade6a
hack all workloads to use prefetch
gonidelis 1f58325
Make BlockLoadPrefetch a compile-time parameter to BlockLoad
gonidelis f6fd431
enable prefetching in reduce_by_key benchmark
gonidelis 4d41b1a
Fix ::cub:: qualified prefetch call in wrapped-namespace builds
gonidelis 76fb6ab
expose stride as a parameter for prefetching
gonidelis 2f64d28
Move load_prefetch after load_modifier in ReduceByKeyPolicy and other…
gonidelis 29335c5
move blockloadprefetch in detail namespace
gonidelis 7ecaf9b
revert load_prefetch field ordering in ReduceByKeyPolicy to not break…
gonidelis 965b5f3
fix RleEncodePolicy adapter: drop missing load_prefetch field
gonidelis 09270c9
remove libcudacxx ptx prefetch wrappers
gonidelis 9e42ac4
- remove cacheloadmodified iterator handling and document it in note
gonidelis 2664eca
reviews and ci fix
gonidelis 82cf82b
Introduce TMA prefetch path for sm90+
gonidelis 85dbadf
move prefetch enum place so no forward declaration is needed
gonidelis b97fd44
encode reducebykey prefetch (non-tma) tunings run
gonidelis 0030373
port reducebykey prefetch tunings to the live policy_selector (new tu…
gonidelis c8b9cd0
use block_elect_one instead of tid=0
gonidelis d99482b
properly align base and size to 16bytes per ISA instructions
gonidelis 23a17d4
enable prefetch for all BlockLoad algorithms
gonidelis 8df100a
strip reducebyekey integration
gonidelis 94962d3
Restore catch2_test_device_reduce_env.cu to merge-base
gonidelis 6b12878
add tests
gonidelis 8e46ea3
Reintroduce reduce_by_key prefetch integration on top of generalized …
gonidelis 62def43
strip tunings from old tuning policy API
gonidelis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Performance & Scalability | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
Repository: NVIDIA/cccl
Length of output: 260
🏁 Script executed:
Repository: NVIDIA/cccl
Length of output: 551
🏁 Script executed:
Repository: NVIDIA/cccl
Length of output: 21012
important: prefetch needs the unwrapped input iterator
prefetch_block_load_tileis suppressed forCacheModifiedInputIterator, so calling it ond_keys_in + tile_offset/d_values_in + tile_offsetis a no-op for raw-pointer inputs. That leavesLOAD_PREFETCHineffective on the common pointer-basedDeviceReduce::ReduceByKeypath; prefetch the raw pointer before wrapping, or use a separate unwrapped prefetch path.