-
Notifications
You must be signed in to change notification settings - Fork 586
docs: document speculation profiles and how to produce them #2316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yeyu-nvidia
wants to merge
27
commits into
NVIDIA:main
Choose a base branch
from
yeyu-nvidia:yeyu/speculation-profile-docs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 10 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
cafd30e
specdec_bench: emit speculation_profile.json alongside acceptance met…
yeyu-nvidia 878421c
specdec_bench: derive K from the flag each method actually uses
yeyu-nvidia c170403
specdec_bench: address review — publishable ids, per-run state, __all__
yeyu-nvidia 095124e
specdec_bench: make mean accept length per-step, not per-request
yeyu-nvidia 2f235bf
export: attach speculation_profile.json to exported draft checkpoints
yeyu-nvidia f0b449f
Merge remote-tracking branch 'origin/main' into yeyu/speculation-profile
yeyu-nvidia 7e0c488
Merge branch 'yeyu/speculation-profile' into yeyu/speculation-profile…
yeyu-nvidia dad7965
ar_validate: emit a speculation profile from in-training AR validation
yeyu-nvidia e829928
Merge branch 'yeyu/speculation-profile-ar-validate' into yeyu/specula…
yeyu-nvidia 35ed318
docs: document speculation profiles and how to produce them
yeyu-nvidia 1c6ddd3
specdec_bench: fix dump_env regression and sparse-histogram gaps
yeyu-nvidia 77df762
Merge branch 'yeyu/speculation-profile' into yeyu/speculation-profile…
yeyu-nvidia edf879d
Merge branch 'yeyu/speculation-profile' into yeyu/speculation-profile…
yeyu-nvidia cde2c7e
Merge branch 'yeyu/speculation-profile-export' into yeyu/speculation-…
yeyu-nvidia b2beb8d
Merge branch 'yeyu/speculation-profile-ar-validate' into yeyu/specula…
yeyu-nvidia 43e57bf
specdec_bench: validate rates, empty measurements and verification me…
yeyu-nvidia d67c3cb
Merge branch 'yeyu/speculation-profile' into yeyu/speculation-profile…
yeyu-nvidia 0f55e88
export: reject malformed JSON on the parser path
yeyu-nvidia 0d9549c
Merge branch 'yeyu/speculation-profile' into yeyu/speculation-profile…
yeyu-nvidia 5b8a346
ar_validate: do not emit a profile from an empty measurement
yeyu-nvidia b63033c
Merge branch 'yeyu/speculation-profile-export' into yeyu/speculation-…
yeyu-nvidia a4484d0
Merge branch 'yeyu/speculation-profile-ar-validate' into yeyu/specula…
yeyu-nvidia 8ba9025
specdec_bench: fix two lint errors CI caught that local pre-commit mi…
yeyu-nvidia c618645
Merge branch 'yeyu/speculation-profile' into yeyu/speculation-profile…
yeyu-nvidia cf91f56
Merge branch 'yeyu/speculation-profile' into yeyu/speculation-profile…
yeyu-nvidia 3edd60d
Merge branch 'yeyu/speculation-profile-export' into yeyu/speculation-…
yeyu-nvidia 0facffa
Merge branch 'yeyu/speculation-profile-ar-validate' into yeyu/specula…
yeyu-nvidia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
Keep
dump_env()out of the no-save branch.The new
elseat Line 269 capturesdump_env()on Lines 273-276. A run without--save_dirnow reachesos.makedirs(None)and fails before benchmarking. A run with--save_dirno longer writesconfiguration.json.Keep
dump_env()in the save-directory branch. Keep metadata clearing in a separate no-save branch.🤖 Prompt for AI Agents