Skip to content

Update wave prep directory for Functional CTest C48_S2SW for gfs_fcst_seg0 - #5280

Merged
DavidHuber-NOAA merged 3 commits into
NOAA-EMC:developfrom
TerrenceMcGuinness-NOAA:feature/ci-hist_init
Sep 15, 2026
Merged

Update wave prep directory for Functional CTest C48_S2SW for gfs_fcst_seg0#5280
DavidHuber-NOAA merged 3 commits into
NOAA-EMC:developfrom
TerrenceMcGuinness-NOAA:feature/ci-hist_init

Conversation

@TerrenceMcGuinness-NOAA

@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA commented Sep 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

These update should enable the operability of functional CTest C48_S2SW

  • Rename model/wave/prep to model/wave/init in C48_S2SW-gfs_fcst_seg0.yaml
  • Rename model/wave/prep to model/wave/init in C48_S2SW-gfs_waveinit.yaml
  • Rename model/wave/prep to model/wave/init in C48_S2SW-gfs_wavepostbndpnt.yaml
  • Rename model/wave/prep to model/wave/init in C48_S2SW-gfs_wavepostbndpntbll.yaml
  • Rename model/wave/prep to model/wave/init in C48_S2SW-gfs_wavepostpnt.yaml
  • Rename model/wave/prep to model/wave/init in C48_S2SW-gfs_wavepostsbs_f000-f002.yaml
  • Updates directory naming to align with wave model initialization stage nomenclature

We can not run these tests with a CI pipeline with this PR because this PR has a change in logic within the default pipeline script .gitlab.yml itself.

Tested on disk

Terry.McGuinness (gaea64) build (feature/ci-hist_init) $ ctest -j 100
Test project /gpfs/f6/drsa-precip3/scratch/Terry.McGuinness/global-workflow_forked/dev/ctests/build
      Start 37: test_C48_S2SW-gfs_waveinit_setup
      Start 25: test_C48_S2SW-gfs_fcst_seg0_setup
      Start 33: test_C48_S2SW-gfs_ocean_prod_f006_setup
      Start 21: test_C48_S2SW-gfs_stage_ic_setup
      Start 53: test_C48_S2SW-gfs_wavepostbndpntbll_setup
      Start 41: test_C48_S2SW-gfs_wavepostpnt_setup
      Start 29: test_C48_S2SW-gfs_ice_prod_f006_setup
      Start 49: test_C48_S2SW-gfs_wavepostbndpnt_setup
      Start 45: test_C48_S2SW-gfs_wavepostgridded_f000-f002_setup
      Start 17: test_C48_ATM-gfs_genesis_setup
      Start  1: test_C48_ATM-gfs_stage_ic_setup
      Start  5: test_C48_ATM-gfs_fcst_seg0_setup
      Start  9: test_C48_ATM-gfs_atmos_prod_f000-f002_setup
      Start 13: test_C48_ATM-gfs_tracker_setup
      Start 57: test_C48_S2SWA_gefs-gefs_fcst_mem001_seg0_setup
 1/60 Test #13: test_C48_ATM-gfs_tracker_setup .........................   Passed    3.15 sec
      Start 14: test_C48_ATM-gfs_tracker_stage
 2/60 Test #17: test_C48_ATM-gfs_genesis_setup .........................   Passed    3.16 sec
      Start 18: test_C48_ATM-gfs_genesis_stage
 3/60 Test  #5: test_C48_ATM-gfs_fcst_seg0_setup .......................   Passed    3.16 sec
      Start  6: test_C48_ATM-gfs_fcst_seg0_stage
 4/60 Test  #1: test_C48_ATM-gfs_stage_ic_setup ........................   Passed    3.16 sec
      Start  2: test_C48_ATM-gfs_stage_ic_stage
 5/60 Test  #9: test_C48_ATM-gfs_atmos_prod_f000-f002_setup ............   Passed    3.16 sec
      Start 10: test_C48_ATM-gfs_atmos_prod_f000-f002_stage
 6/60 Test #57: test_C48_S2SWA_gefs-gefs_fcst_mem001_seg0_setup ........   Passed    3.23 sec
      Start 58: test_C48_S2SWA_gefs-gefs_fcst_mem001_seg0_stage
 7/60 Test #41: test_C48_S2SW-gfs_wavepostpnt_setup ....................   Passed    3.33 sec
      Start 42: test_C48_S2SW-gfs_wavepostpnt_stage
 8/60 Test #33: test_C48_S2SW-gfs_ocean_prod_f006_setup ................   Passed    3.34 sec
      Start 34: test_C48_S2SW-gfs_ocean_prod_f006_stage
 9/60 Test #37: test_C48_S2SW-gfs_waveinit_setup .......................   Passed    3.35 sec
      Start 38: test_C48_S2SW-gfs_waveinit_stage
10/60 Test #45: test_C48_S2SW-gfs_wavepostgridded_f000-f002_setup ......   Passed    3.34 sec
      Start 46: test_C48_S2SW-gfs_wavepostgridded_f000-f002_stage
11/60 Test #25: test_C48_S2SW-gfs_fcst_seg0_setup ......................   Passed    3.35 sec
      Start 26: test_C48_S2SW-gfs_fcst_seg0_stage
12/60 Test #53: test_C48_S2SW-gfs_wavepostbndpntbll_setup ..............   Passed    3.35 sec
      Start 54: test_C48_S2SW-gfs_wavepostbndpntbll_stage
13/60 Test #49: test_C48_S2SW-gfs_wavepostbndpnt_setup .................   Passed    3.35 sec
      Start 50: test_C48_S2SW-gfs_wavepostbndpnt_stage
14/60 Test #29: test_C48_S2SW-gfs_ice_prod_f006_setup ..................   Passed    3.35 sec
      Start 30: test_C48_S2SW-gfs_ice_prod_f006_stage
15/60 Test #21: test_C48_S2SW-gfs_stage_ic_setup .......................   Passed    3.36 sec
      Start 22: test_C48_S2SW-gfs_stage_ic_stage
16/60 Test  #2: test_C48_ATM-gfs_stage_ic_stage ........................   Passed    1.56 sec
      Start  3: test_C48_ATM-gfs_stage_ic_execute
17/60 Test #30: test_C48_S2SW-gfs_ice_prod_f006_stage ..................   Passed    1.44 sec
      Start 31: test_C48_S2SW-gfs_ice_prod_f006_execute
18/60 Test #38: test_C48_S2SW-gfs_waveinit_stage .......................   Passed    1.45 sec
      Start 39: test_C48_S2SW-gfs_waveinit_execute
19/60 Test #22: test_C48_S2SW-gfs_stage_ic_stage .......................   Passed    1.46 sec
      Start 23: test_C48_S2SW-gfs_stage_ic_execute
20/60 Test #34: test_C48_S2SW-gfs_ocean_prod_f006_stage ................   Passed    1.50 sec
      Start 35: test_C48_S2SW-gfs_ocean_prod_f006_execute
21/60 Test #10: test_C48_ATM-gfs_atmos_prod_f000-f002_stage ............   Passed    2.08 sec
      Start 11: test_C48_ATM-gfs_atmos_prod_f000-f002_execute
22/60 Test  #6: test_C48_ATM-gfs_fcst_seg0_stage .......................   Passed    3.32 sec
      Start  7: test_C48_ATM-gfs_fcst_seg0_execute
23/60 Test #26: test_C48_S2SW-gfs_fcst_seg0_stage ......................   Passed    5.50 sec
      Start 27: test_C48_S2SW-gfs_fcst_seg0_execute
24/60 Test #46: test_C48_S2SW-gfs_wavepostgridded_f000-f002_stage ......   Passed    5.64 sec
      Start 47: test_C48_S2SW-gfs_wavepostgridded_f000-f002_execute
25/60 Test #58: test_C48_S2SWA_gefs-gefs_fcst_mem001_seg0_stage ........   Passed    9.70 sec
      Start 59: test_C48_S2SWA_gefs-gefs_fcst_mem001_seg0_execute
26/60 Test #42: test_C48_S2SW-gfs_wavepostpnt_stage ....................   Passed   12.52 sec
      Start 43: test_C48_S2SW-gfs_wavepostpnt_execute
27/60 Test #54: test_C48_S2SW-gfs_wavepostbndpntbll_stage ..............   Passed   12.50 sec
      Start 55: test_C48_S2SW-gfs_wavepostbndpntbll_execute
28/60 Test #50: test_C48_S2SW-gfs_wavepostbndpnt_stage .................   Passed   12.50 sec
      Start 51: test_C48_S2SW-gfs_wavepostbndpnt_execute
29/60 Test  #3: test_C48_ATM-gfs_stage_ic_execute ......................   Passed   60.80 sec
      Start  4: test_C48_ATM-gfs_stage_ic_validate
30/60 Test #35: test_C48_S2SW-gfs_ocean_prod_f006_execute ..............   Passed   60.79 sec
      Start 36: test_C48_S2SW-gfs_ocean_prod_f006_validate
31/60 Test #23: test_C48_S2SW-gfs_stage_ic_execute .....................   Passed   60.81 sec
      Start 24: test_C48_S2SW-gfs_stage_ic_validate
32/60 Test #31: test_C48_S2SW-gfs_ice_prod_f006_execute ................   Passed   60.84 sec
      Start 32: test_C48_S2SW-gfs_ice_prod_f006_validate
33/60 Test #39: test_C48_S2SW-gfs_waveinit_execute .....................   Passed   60.85 sec
      Start 40: test_C48_S2SW-gfs_waveinit_validate
34/60 Test #36: test_C48_S2SW-gfs_ocean_prod_f006_validate .............   Passed    1.49 sec
35/60 Test #32: test_C48_S2SW-gfs_ice_prod_f006_validate ...............   Passed    1.48 sec
36/60 Test #40: test_C48_S2SW-gfs_waveinit_validate ....................   Passed    1.48 sec
37/60 Test  #4: test_C48_ATM-gfs_stage_ic_validate .....................   Passed    1.59 sec
38/60 Test #24: test_C48_S2SW-gfs_stage_ic_validate ....................   Passed    1.50 sec
39/60 Test #47: test_C48_S2SW-gfs_wavepostgridded_f000-f002_execute ....   Passed  120.68 sec
      Start 48: test_C48_S2SW-gfs_wavepostgridded_f000-f002_validate
40/60 Test #48: test_C48_S2SW-gfs_wavepostgridded_f000-f002_validate ...   Passed    1.49 sec
41/60 Test #51: test_C48_S2SW-gfs_wavepostbndpnt_execute ...............   Passed  180.71 sec
      Start 52: test_C48_S2SW-gfs_wavepostbndpnt_validate
42/60 Test #52: test_C48_S2SW-gfs_wavepostbndpnt_validate ..............   Passed    1.49 sec
43/60 Test #43: test_C48_S2SW-gfs_wavepostpnt_execute ..................   Passed  240.75 sec
      Start 44: test_C48_S2SW-gfs_wavepostpnt_validate
44/60 Test #44: test_C48_S2SW-gfs_wavepostpnt_validate .................   Passed    1.44 sec
45/60 Test #11: test_C48_ATM-gfs_atmos_prod_f000-f002_execute ..........   Passed  300.88 sec
      Start 12: test_C48_ATM-gfs_atmos_prod_f000-f002_validate
46/60 Test #12: test_C48_ATM-gfs_atmos_prod_f000-f002_validate .........   Passed    1.44 sec
47/60 Test #55: test_C48_S2SW-gfs_wavepostbndpntbll_execute ............   Passed  480.86 sec
      Start 56: test_C48_S2SW-gfs_wavepostbndpntbll_validate
48/60 Test #56: test_C48_S2SW-gfs_wavepostbndpntbll_validate ...........   Passed    1.51 sec
49/60 Test #59: test_C48_S2SWA_gefs-gefs_fcst_mem001_seg0_execute ......   Passed  600.94 sec
      Start 60: test_C48_S2SWA_gefs-gefs_fcst_mem001_seg0_validate
50/60 Test #60: test_C48_S2SWA_gefs-gefs_fcst_mem001_seg0_validate .....   Passed    1.54 sec
51/60 Test  #7: test_C48_ATM-gfs_fcst_seg0_execute .....................   Passed  900.98 sec
      Start  8: test_C48_ATM-gfs_fcst_seg0_validate
52/60 Test  #8: test_C48_ATM-gfs_fcst_seg0_validate ....................   Passed    1.89 sec
53/60 Test #27: test_C48_S2SW-gfs_fcst_seg0_execute ....................   Passed  961.07 sec
      Start 28: test_C48_S2SW-gfs_fcst_seg0_validate
54/60 Test #28: test_C48_S2SW-gfs_fcst_seg0_validate ...................   Passed    2.49 sec
55/60 Test #18: test_C48_ATM-gfs_genesis_stage .........................   Passed  2022.51 sec
      Start 19: test_C48_ATM-gfs_genesis_execute
56/60 Test #14: test_C48_ATM-gfs_tracker_stage .........................   Passed  2022.52 sec
      Start 15: test_C48_ATM-gfs_tracker_execute
57/60 Test #15: test_C48_ATM-gfs_tracker_execute .......................   Passed  120.81 sec
      Start 16: test_C48_ATM-gfs_tracker_validate
58/60 Test #16: test_C48_ATM-gfs_tracker_validate ......................   Passed    1.65 sec
59/60 Test #19: test_C48_ATM-gfs_genesis_execute .......................   Passed  481.00 sec
      Start 20: test_C48_ATM-gfs_genesis_validate
60/60 Test #20: test_C48_ATM-gfs_genesis_validate ......................   Passed    1.48 sec

100% tests passed, 0 tests failed out of 60

Label Time Summary:
C48_ATM-gfs_atmos_prod_f000-f002          = 307.56 sec*proc (4 tests)
C48_ATM-gfs_fcst_seg0                     = 909.35 sec*proc (4 tests)
C48_ATM-gfs_genesis                       = 2508.15 sec*proc (4 tests)
C48_ATM-gfs_stage_ic                      =  67.11 sec*proc (4 tests)
C48_ATM-gfs_tracker                       = 2148.13 sec*proc (4 tests)
C48_S2SW-gfs_fcst_seg0                    = 972.42 sec*proc (4 tests)
C48_S2SW-gfs_ice_prod_f006                =  67.11 sec*proc (4 tests)
C48_S2SW-gfs_ocean_prod_f006              =  67.12 sec*proc (4 tests)
C48_S2SW-gfs_stage_ic                     =  67.13 sec*proc (4 tests)
C48_S2SW-gfs_waveinit                     =  67.13 sec*proc (4 tests)
C48_S2SW-gfs_wavepostbndpnt               = 198.05 sec*proc (4 tests)
C48_S2SW-gfs_wavepostbndpntbll            = 498.22 sec*proc (4 tests)
C48_S2SW-gfs_wavepostgridded_f000-f002    = 131.14 sec*proc (4 tests)
C48_S2SW-gfs_wavepostpnt                  = 258.03 sec*proc (4 tests)
C48_S2SWA_gefs-gefs_fcst_mem001_seg0      = 615.40 sec*proc (4 tests)

Total Test time (real) = 2508.19 sec
Terry.McGuinness (gaea64) build (feature/ci-hist_init) $

@AntonMFernando-NOAA
chore(ctests): rename wave prep directory to init across test cases
c6856f6 
- Rename model/wave/prep to model/wave/init in C48_S2SW-gfs_fcst_seg0.yaml
- Rename model/wave/prep to model/wave/init in C48_S2SW-gfs_waveinit.yaml
- Rename model/wave/prep to model/wave/init in C48_S2SW-gfs_wavepostbndpnt.yaml
- Rename model/wave/prep to model/wave/init in C48_S2SW-gfs_wavepostbndpntbll.yaml
- Rename model/wave/prep to model/wave/init in C48_S2SW-gfs_wavepostpnt.yaml
- Rename model/wave/prep to model/wave/init in C48_S2SW-gfs_wavepostsbs_f000-f002.yaml
- Updates directory naming to align with wave model initialization stage nomenclature
Copilot AI lite review requested due to automatic review settings September 14, 2026 18:39
@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA added the CI/CD Issue related to CI/CD label Sep 14, 2026
@github-actions

github-actions Bot commented Sep 14, 2026 •
edited
Loading

Copy link
Copy Markdown

Bash code analysis

✅ shellcheck and shfmt found no issues.

View the analysis run

Copilot AI reviewed Sep 14, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The path updates are consistent across all reviewed files; the remaining comment mismatch is a minor nit and does not block approval.

Pull request overview

Updates C48_S2SW wave CTest fixtures to use model/wave/init instead of model/wave/prep.

Changes:

  • Renamed wave initialization paths across six test cases.
  • Updated directory creation, input copies, and output comparisons.
  • One workflow comment still references the old wave prep directory.
File summaries
File Summary
dev/ctests/cases/C48_S2SW-gfs_wavepostsbs_f000-f002.yaml Updates gridded post-processing paths.
dev/ctests/cases/C48_S2SW-gfs_wavepostpnt.yaml Updates point post-processing paths.
dev/ctests/cases/C48_S2SW-gfs_wavepostbndpntbll.yaml Updates boundary bulletin paths.
dev/ctests/cases/C48_S2SW-gfs_wavepostbndpnt.yaml Updates boundary-point paths.
dev/ctests/cases/C48_S2SW-gfs_waveinit.yaml Uses the renamed initialization directory.
dev/ctests/cases/C48_S2SW-gfs_fcst_seg0.yaml Uses wave initialization inputs from model/wave/init.
Review details
  • Files reviewed: 6/6 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread dev/ctests/cases/C48_S2SW-gfs_waveinit.yaml
@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA changed the title chore(ctests): rename wave prep directory to init across test cases Update wave prep directory for Functional CTest C48_S2SW for gfs_fcst_seg0 Sep 14, 2026
@TerrenceMcGuinness-NOAA
TerrenceMcGuinness-NOAA marked this pull request as draft September 14, 2026 22:01
@emcbot emcbot added the CI-Gaeac6-Ready **CM use only** PR is ready for CI testing on Gaea C6 label Sep 14, 2026
@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA removed the CI-Gaeac6-Ready **CM use only** PR is ready for CI testing on Gaea C6 label Sep 15, 2026
@emcbot emcbot added the CI-Gaeac6-Ready **CM use only** PR is ready for CI testing on Gaea C6 label Sep 15, 2026
@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA removed the CI-Gaeac6-Ready **CM use only** PR is ready for CI testing on Gaea C6 label Sep 15, 2026
@TerrenceMcGuinness-NOAA
TerrenceMcGuinness-NOAA marked this pull request as ready for review September 15, 2026 02:50
DavidHuber-NOAA
DavidHuber-NOAA approved these changes Sep 15, 2026
View reviewed changes

@DavidHuber-NOAA DavidHuber-NOAA left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @TerrenceMcGuinness-NOAA!

@DavidHuber-NOAA

DavidHuber-NOAA commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the leg work @AntonMFernando-NOAA!

@DavidHuber-NOAA
DavidHuber-NOAA merged commit 3f85760 into NOAA-EMC:develop Sep 15, 2026
5 checks passed
@AlexanderHrabski-NOAA AlexanderHrabski-NOAA mentioned this pull request Sep 15, 2026
Merged
9 of 13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@DavidHuber-NOAA DavidHuber-NOAA DavidHuber-NOAA approved these changes
@TravisElless-NOAA TravisElless-NOAA Awaiting requested review from TravisElless-NOAA TravisElless-NOAA is a code owner

Assignees

@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA

Labels

CI/CD Issue related to CI/CD

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@TerrenceMcGuinness-NOAA @DavidHuber-NOAA @emcbot @AntonMFernando-NOAA