Skip to content

Restore the vtable pointer of received cache nodes #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trquinn merged 2 commits into from
Sep 29, 2026
Merged

Restore the vtable pointer of received cache nodes #229

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
701f15b
Restore the vtable pointer of received cache nodes
lvkale Sep 27, 2026
9fe84bf
Correct the vptr comment in EntryTypeGravityNode's constructor
lvkale Sep 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions CacheInterface.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,11 +380,13 @@ void EntryTypeGravityNode::unpackSingle(CkCacheFillMsg<KeyType> *msg, Tree::Bina

*(CkCacheFillMsg<KeyType> **) (((char*)node)-PAD_reply) = msg;

// Overwrite virtual pointer table. Something like this will be
// needed for heterogeneous architectures. Commented out for now
// since it breaks on the PGI compiler.
// Restore the virtual function table pointer: the nodes arrive as raw
// bytes from another process, and where processes map the executable
// at different addresses (position-independent executables under
// address-space randomization, e.g. macOS) the sender's pointer is not
// valid here. Harmless where the addresses agree.

// memcpy(node, &vptr, sizeof(void*));
memcpy(node, &vptr, sizeof(void*));

if (!isRoot) CmiReference(UsrToEnv(msg));
for (int i=0; i < 2; ++i) {
Expand Down
Loading