Skip to content

[app-builder] fix: avoid NullPointerException for unknown HTTP status codes (#595) #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
loveTsong merged 2 commits into from
Feb 12, 2026
Merged

[app-builder] fix: avoid NullPointerException for unknown HTTP status codes (#595) #596

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5ea9b3
[app-builder] fix: avoid NullPointerException for unknown HTTP status…
loveTsong Feb 11, 2026
db094ff
[app-builder] test: add unit tests for DataMateKnowledgeBaseManager
loveTsong Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...n/java/modelengine/fit/jade/datamate/knowledge/external/DataMateKnowledgeBaseManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,8 +136,9 @@ public DataMateRetrievalResult retrieve(String apiKey, DataMateRetrievalParam pa

private KnowledgeException handleException(HttpClientResponseException ex) {
int statusCode = ex.statusCode();
log.error(this.exceptionMap.get(statusCode).getMsg(), ex);
return new KnowledgeException(this.exceptionMap.get(statusCode), ex, ex.getSimpleMessage());
KnowledgeManagerRetCode retCode = this.exceptionMap.getOrDefault(statusCode, INTERNAL_SERVICE_ERROR);

@loveTsong loveTsong Feb 11, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

缺少单元测试覆盖

log.error(retCode.getMsg(), ex);
return new KnowledgeException(retCode, ex, ex.getSimpleMessage());
}

private HttpClassicClient getHttpClient() {
Expand Down
5 changes: 3 additions & 2 deletions ...wledge/src/main/java/modelengine/jade/knowledge/external/QianfanKnowledgeBaseManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,8 +119,9 @@ public QianfanRetrievalResult retrieve(String apiKey, QianfanRetrievalParam para

private KnowledgeException handleException(HttpClientResponseException ex) {
int statusCode = ex.statusCode();
log.error(this.exceptionMap.get(statusCode).getMsg(), ex);
return new KnowledgeException(this.exceptionMap.get(statusCode), ex.getSimpleMessage());
KnowledgeManagerRetCode retCode = this.exceptionMap.getOrDefault(statusCode, INTERNAL_SERVICE_ERROR);

@loveTsong loveTsong Feb 11, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

缺少单元测试覆盖

log.error(retCode.getMsg(), ex);
return new KnowledgeException(retCode, ex.getSimpleMessage());
}

private HttpClassicClient getHttpClient() {
Expand Down
Loading