Avoid private Scotch sorting symbol - #329
Open
prudhomm wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #329 +/- ##
===========================================
- Coverage 50.31% 50.25% -0.07%
===========================================
Files 177 177
Lines 47831 47844 +13
Branches 10352 10350 -2
===========================================
- Hits 24065 24042 -23
- Misses 16037 16073 +36
Partials 7729 7729 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
prudhomm
added a commit
to feelpp/feelpp
that referenced
this pull request
Aug 24, 2026
Refs #2511. Uses the MMG Scotch fix from MmgTools/mmg#329. Updates to the ParMmg CMake package support merged in MmgTools/ParMmg#137.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the private
_SCOTCHintSort2asc1call with a localqsortcomparator and test CI against Scotch 7.0.11. Fixes #328.