Repository navigation
fix(web3): keep pending transaction status in sync - #6805
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
de4b308 to
7e33969
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ccef70e6c1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| web3TransactionDao.insertSuspend(remote) | ||
| return remote |
There was a problem hiding this comment.
When the detail-screen refresh overlaps with PendingTransactionRefreshHelper, a response containing pending can arrive after the helper has already persisted a terminal status. Since insertSuspend uses REPLACE, this unconditionally restores the transaction to pending, and refreshPendingTransaction() also changes the displayed status back. The raw transaction is already terminal at that point, so getPendingRawTransactions() excludes it and subsequent polling cannot repair the status. Make the persistence check atomic and prevent a pending response from overwriting an already-terminal local transaction; return the retained status to the UI as well.
Useful? React with 👍 / 👎.
This reverts commit 25b056a.
No description provided.