Conversation
atengler
force-pushed
the
helm-experimental
branch
from
January 24, 2018 14:01
79ea202 to
a4ed98a
Compare
tomkukral
suggested changes
Feb 1, 2018
tomkukral
left a comment
tomkukral
left a comment
Contributor
There was a problem hiding this comment.
Nice preview but we can't pack kubectl binary into our code.
Helm feature can't be implemented due to missing support for forwarding in Kubernetes python client.
Contributor
|
Related: https://github.com/appscode/swift (tiller api proxy) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HelmWrapper POC