Repository navigation
fix: return after resolve in wipeCollectorStorage guards - #6671
Merged
timothycarambat merged 2 commits intoOct 9, 2026
Merged
timothycarambat merged 2 commits into
timothycarambat merged 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Relevant Issues
resolves #6669
Description
wipeCollectorStoragecalledresolve()in its guards (missing hotdir,readdirerror on hotdir,readdirerror onstorage/tmp) without returning. Execution then fell through tofor (const file of files)withfilesundefined, throwingTypeError: files is not iterableinside thereaddircallback. That is an uncaught exception, so the collector crashed at boot when the hotdir orstorage/tmpwas missing.The guards now
return resolve(), so boot continues.Additional Information
The
fs.rmSynccall withoutrecursiveis untouched and out of scope here.Developer Validations
yarn lintfrom the root of the repo & committed changesCollector
yarn lint:checkpasses andyarn test collectorpasses (14 suites, 408 tests).