Repository navigation
fix(collector): stop treating binary types with no converter as text - #6670
Merged
timothycarambat merged 2 commits intoOct 9, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Relevant Issues
resolves #6667
Description
Files whose extension has no entry in
SUPPORTED_FILETYPE_CONVERTERSgo throughisTextType().isKnownTextMime()only rejects MIMEs listed inbadMimesor whose top-level type is innonTextTypes, so.gif,.bmp,.tiff/.tif,.heic,.doc,.xls,.ppt,.rarand.7zwere classified as text and ingested through the.txtconverter as garbage.This adds their MIME types (plus
image/heif, the sibling ofimage/heic) tobadMimes, so they are rejected with the existing "not supported for parsing and cannot be assumed as text file type" message, like.exeor.zip. Types that have a converter (png, jpg, webp, etc.) are unaffected because the converter lookup happens beforeisTextType()is called. No image support is added.Additional Information
Other binary MIMEs not covered by the issue (e.g. gzip/tar archives) still pass through the MIME check; left out to keep this change scoped to the reported types.
Developer Validations
yarn lintfrom the root of the repo & committed changes