Repository navigation
fix: add request timeout and malformed-envelope guard to AnySearch search - #6664
Closed
tbontb-iaq wants to merge 1 commit into
Closed
tbontb-iaq wants to merge 1 commit into
tbontb-iaq wants to merge 1 commit into
Conversation
Member
|
Thanks for trimming this down, and sorry #6466 got closed without an explanation. We're going to pass on this one. Neither change fixes a failure anyone has run into. Node's fetch already gives up after about 5 minutes, and we haven't seen AnySearch return |
Contributor
Author
|
Understood, thanks for taking the time to explain — appreciated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Small robustness fixes for the AnySearch agent web-search provider added in #6439:
AbortSignal.timeout) so a hanging API call can't stall the agent invocation indefinitely.code: 0envelope missingdata.resultsas an explicit error instead of silently reporting "no results found", which made malformed responses indistinguishable from genuine empty results.Single file, no behavior change on the happy path.
Context
My earlier follow-up #6466 was closed without feedback, and a comment asking which parts might be acceptable went unanswered — so rather than guess, I've reduced this to the smallest, most isolated piece from it: 5 lines, no schema changes, no tests, no changes to existing behavior beyond the two failure modes above. Apologies if this is unwanted noise; a plain close with no hard feelings is a fine answer.