Skip to content

fix(social): remove useElevatedSurface shim from Quick Buy BottomSheet (TMCU-1050) #33164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
georgewrmarshall wants to merge 1 commit into from
+1 −7
Closed

fix(social): remove useElevatedSurface shim from Quick Buy BottomSheet (TMCU-1050) #33164

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions ...omponents/Views/SocialLeaderboard/TraderPositionView/components/QuickBuy/QuickBuyRoot.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ import { useSafeAreaInsets } from 'react-native-safe-area-context';
import { useSelector } from 'react-redux';
import { MetaMetricsEvents } from '../../../../../../core/Analytics';
import { selectIsSubmittingTx } from '../../../../../../core/redux/slices/bridge';
import { useElevatedSurface } from '../../../../../../util/theme/themeUtils';
import { QuickBuyEventProperties, QuickBuyEventValues } from './analytics';
import { useSocialLeaderboardAnalytics } from '../../../analytics';
import { TOP_TRADERS_QUICK_BUY_FEATURES } from './features';
Expand Down Expand Up @@ -95,7 +94,6 @@ const QuickBuyRootInner: React.FC<QuickBuyRootInnerProps> = ({
// with the sheet instead of running its horizontal screen-exit transition.
const [isClosing, setIsClosing] = useState(false);
const isSubmittingTx = useSelector(selectIsSubmittingTx);
const surfaceClass = useElevatedSurface();

const directionSV = useSharedValue<ScreenDirection>(1);
// Suppresses the enter animation on the initial screen when the sheet opens;
Expand Down Expand Up @@ -177,11 +175,7 @@ const QuickBuyRootInner: React.FC<QuickBuyRootInnerProps> = ({
activeScreen === 'amount' || activeScreen === 'priceImpactConfirm';

return (
<BottomSheetDialog
ref={bottomSheetRef}
onClose={onClose}
twClassName={surfaceClass}
>
<BottomSheetDialog ref={bottomSheetRef} onClose={onClose}>

@georgewrmarshall georgewrmarshall Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MMDS BottomSheetDialog applies elevated surface styling internally since design-system-react-native 0.33, so twClassName={surfaceClass} was redundant here. useElevatedSurface returned bg-alternative in pure-black dark mode, which BottomSheetDialog now applies via usePureBlack without callsite overrides.

{isContentReady ? (
<QuickBuyProvider
target={target}
Expand Down
Loading