Skip to content

test: revert exact match for create-wallet-account spec#33139

Draft
Prithpal-Sooriya wants to merge 2 commits into
mainfrom
test/revert-exact-match-in-appium-test
Draft

test: revert exact match for create-wallet-account spec#33139
Prithpal-Sooriya wants to merge 2 commits into
mainfrom
test/revert-exact-match-in-appium-test

Conversation

@Prithpal-Sooriya

@Prithpal-Sooriya Prithpal-Sooriya commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Description

Reverts small modification from here: https://github.com/MetaMask/metamask-mobile/pull/32976/changes#diff-e800aef6295a0750e22d797ef81cf53123e025f8934fb2702865be745e063d42

- await AccountListBottomSheet.tapAccountByNameV2('Account 3'); // default send param `exactMatch` is false
+ await AccountListBottomSheet.tapAccountByNameV2('Account 3', true);

See if this helps resolve failing CI

Changelog

CHANGELOG entry: test: revert exact match for create-wallet-account spec

Related issues

Fixes: N/A

Manual testing steps

N/A

Screenshots/Recordings

N/A

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Test-only change to Appium smoke spec with no production code impact.

Overview
Reverts exact-match account tapping in the multi-SRP smoke test so the first selection of Account 3 uses tapAccountByNameV2('Account 3') again (default exactMatch: false) instead of passing true.

The intent is to address failing CI when strict name matching does not align with how Account 3 appears in the list after creation across two SRPs.

Reviewed by Cursor Bugbot for commit 27f6615. Bugbot is set up for automated code reviews on this repo. Configure here.

see if this helps resolve failing CI
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeAccounts
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: medium
  • AI Confidence: 95%
click to see 🤖 AI reasoning details

E2E Test Selection:
Hard rule (test-spec-tag-extraction): Spec files changed directly. Running their associated tags: SmokeAccounts

Performance Test Selection:
This is a test-only change (removing a boolean parameter from a test helper call in a smoke-appium spec). No app code, performance-sensitive flows, or performance spec files were modified. No performance tests are needed.

View GitHub Actions results

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant