fix(ramp): keep amount input visible when opening provider picker (TRAM-3750)#33132
Draft
amitabh94 wants to merge 4 commits into
Draft
fix(ramp): keep amount input visible when opening provider picker (TRAM-3750)#33132amitabh94 wants to merge 4 commits into
amitabh94 wants to merge 4 commits into
Conversation
Close the payment selection bottom sheet before navigating to provider selection instead of stacking both modals. Nested modal screens caused the BuildQuote amount input to disappear behind the overlays (TRAM-3750). Update payment modal and unified-buy component view tests to cover the close-then-navigate flow and provider switch returning to BuildQuote. Co-authored-by: Amitabh Aggarwal <amitabh94@users.noreply.github.com>
github-actions
Bot
added
the
pr-not-ready-for-e2e
mm-token-exchange-service
Bot
added
team-money-movement
Contributor
PR template — items to address before "Ready for review"Warnings — informational, address before merging:
See docs/readme/ready-for-review.md for the full Definition of Ready for Review. |
Return provider-aware quote mocks from setupV2Hooks so MoonPay selection on BuildQuote surfaces Powered by text instead of a no-quotes error. Wait for the provider modal to dismiss before asserting BuildQuote state. Co-authored-by: Amitabh Aggarwal <amitabh94@users.noreply.github.com>
Co-authored-by: Amitabh Aggarwal <amitabh94@users.noreply.github.com>
Pass returnToPaymentSelection when opening provider picker from the payment sheet. On provider select, close the provider sheet and navigate back to payment selection so the user can confirm payment for the new provider. Dismiss (outside tap / swipe) still returns to BuildQuote. Fixes TRAM-3750 while restoring the intended post-select UX without re-stacking modal screens. Co-authored-by: Amitabh Aggarwal <amitabh94@users.noreply.github.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On UB2 BuildQuote, tapping Change provider from the payment selection sheet stacked a second modal on top of the first. That nested modal stack hid the amount input on the underlying BuildQuote screen (reported in production 8.3.0 / build #6000).
This change closes the payment bottom sheet before opening provider selection, matching the pattern already used by
TokenNotAvailableModal. Only one ramp modal is active at a time, so the amount input remains visible in the background.After the user selects a provider, they return to the payment selection sheet (not BuildQuote) so they can pick/confirm payment for the new provider. Dismissing the provider sheet (outside tap, swipe, or back) returns to BuildQuote — fixing production's incorrect dismiss → payment behavior.
Related issues
Fixes TRAM-3750
Manual testing
Validation
yarn jest app/components/UI/Ramp/Views/Modals/PaymentSelectionModal/PaymentSelectionModal.test.tsx --runInBand --silent --coverage=falseyarn jest app/components/UI/Ramp/Views/Modals/ProviderSelectionModal/ProviderSelectionModal.test.tsx --runInBand --silent --coverage=falseTEST_OS=ios yarn jest -c jest.config.view.js app/components/UI/Ramp/Views/BuildQuote/BuildQuote.view.test.tsx --runInBand --coverage=false