Stencil support for lfric domain kernels (testing only)

[Alan J Hewitt (alanjhewitt)]

PR Summary

Sci/Tech Reviewer:
Code Reviewer:

This is to test Andy Porter psyclone development.

I have removed invoke_jules_exp_kernel_type from psykal_lite_phys_mod.F90

• linked Add stencil support for LFRic domain kernels (#1948) stfc/PSyclone#3572

Code Quality Checklist

• I have performed a self-review of my own code
• My code follows the project's style guidelines
• Comments have been included that aid understanding and enhance the readability of the code
• My changes generate no new warnings
• All automated checks in the CI pipeline have completed successfully

Testing

• I have tested this change locally, using the LFRic Apps rose-stem suite
• If any tests fail (rose-stem or CI) the reason is understood and acceptable (e.g. kgo changes)
• I have added tests to cover new functionality as appropriate (e.g. system tests, unit tests, etc.)
• Any new tests have been assigned an appropriate amount of compute resource and have been allocated to an appropriate testing group (i.e. the developer tests are for jobs which use a small amount of compute resource and complete in a matter of minutes)

trac.log

Security Considerations

• I have reviewed my changes for potential security issues
• Sensitive data is properly handled (if applicable)
• Authentication and authorisation are properly implemented (if applicable)

Performance Impact

• Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

• Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

• Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

PSyclone Approval

• If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the HPC Optimisation Team

Sci/Tech Review

• I understand this area of code and the changes being added
• The proposed changes correspond to the pull request description
• Documentation is sufficient (do documentation papers need updating)
• Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

• All dependencies have been resolved
• Related Issues have been properly linked and addressed
• CLA compliance has been confirmed
• Code quality standards have been met
• Tests are adequate and have passed
• Documentation is complete and accurate
• Security considerations have been addressed
• Performance impact is acceptable

[Alan J Hewitt (alanjhewitt)]

Making a note of commands used in workaround so that lfric_apps sees the local checked out psyclone branch

module use /home/users/lfricadmin/lmod
module load lfric/vn3.2
module unload py-psyclone

Just in case
module list psyclone
which psyclone

(In the root of the clone)
python3.12 -m venv .venv
(load the env)
source .venv/bin/activate
(install fabtoy into it)
pip install -e .

I have put a link to the local branch of psyclone inside my lfric_apps branch
Make sure that the working branch in that directory is 1948_stencils_for_domain

Then run rose-stem
cylc vip -z group=all -n test_stencil_support ./rose-stem

or for command line build
source <directory of psyclone>/.venv/bin/activate

[Alan J Hewitt (alanjhewitt)]

note that interfaces/physics_schemes_interface/source/psy/psykal_lite_phys_mod.F90 has a mix of unusual grammar (both jinger2 and bash). i get the general idea of what it is doing, but may need to get more familiar if i need to work on a similar problem a second time.

[Alan J Hewitt (alanjhewitt)]

command line build
source <directory of psyclone>/.venv/bin/activate

Load the required environment
$ ml use ~lfricadmin/lmod
Load the GNU compiler setup for LFRic
$ ml lfric
Launch the local build
$ ./build/local_build.py lfric_atm