Skip to content

Abort analyse step when parse errors occur - #578

Open
jordansilly77-stack wants to merge 1 commit into
MetOffice:mainfrom
jordansilly77-stack:codex/abort-on-analysis-errors
Open

jordansilly77-stack wants to merge 1 commit into
MetOffice:mainfrom
jordansilly77-stack:codex/abort-on-analysis-errors

Conversation

@jordansilly77-stack

Copy link
Copy Markdown

Summary

  • stop the analyse step when parser errors are returned
  • reuse the existing check_for_errors helper for consistent step behaviour
  • update the unit test to assert parse errors halt the build

Closes #577.

Tests

  • .venv/bin/python -m pytest tests/unit_tests/steps/test_analyse.py tests/unit_tests/steps/test_steps.py
  • .venv/bin/python -m flake8 source/fab/steps/analyse.py tests/unit_tests/steps/test_analyse.py

I also ran .venv/bin/python -m pytest tests/unit_tests/steps; unrelated test_find_source_files cases fail locally because no Fortran compiler is available.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a useful change but your raising it pointed out that we didn't have a contributors agreement in place. We now do so you'll need to deal with that before this change can progress.

@yaswant Yaswant Pradhan (yaswant) added the cla-required The CLA has not yet been signed by the author of this PR - added by GA label Sep 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-required The CLA has not yet been signed by the author of this PR - added by GA

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Fab does not abort in case of analyse errors

3 participants