scancode.bbclass: [Request for review]: OI-2 Adding bbclass for scancode#1057
scancode.bbclass: [Request for review]: OI-2 Adding bbclass for scancode#1057hmsadiq wants to merge 1 commit into
Conversation
This class is adding the functionality to run scancode utility on code. You can override SCANCODE_FORMAT if you need json output. It assumes scancode is present in PATH and is set in HOSTTOOLS. This belongs to OI-2. Signed-off-by: H M Irfan Sadiq <irfan_sadiq@mentor.com> Signed-off-by: Noor Ahsan <noor_ahsan@mentor.com>
kergoth
left a comment
kergoth
left a comment
There was a problem hiding this comment.
Other than the specific comments already added, this looks reasonable, but you need to determine the long term plans for this class. Is it intended for upstream, i.e. to meta-openembedded? If so, this is the correct location, but if not, meta-mentor-staging isn't the correct place for the class.
|
|
||
| do_scancode_oss[recrdeptask] = "do_scancode_oss do_scancode" | ||
| do_scancode_oss[nostamp] = "1" | ||
| addtask do_scancode_oss after do_scancode |
There was a problem hiding this comment.
The do_scancode_oss task can be removed. Bitbake supports running a specific task against all dependencies recursively on its own now: bitbake --runall=scancode console-image.
| do_scancode() { | ||
| mkdir -p ${DEPLOY_DIR_IMAGE}/scancode | ||
| if [ -d "${S}" ]; then | ||
| scancode ${S} --format ${SCANCODE_FORMAT} ${DEPLOY_DIR_IMAGE}/scancode/${PN}.${EXT} |
There was a problem hiding this comment.
The convention is to no longer write directly to DEPLOY_DIR_IMAGE, but instead allow the sstate state management code to keep track of what it's installed and uninstall to/from that location. I'd suggest doing the same here, following the same pattern as that used by deploy.bbclass.
There was a problem hiding this comment.
Upon further consideration, I'd also suggest moving this to its own subdirectory of DEPLOY_DIR, rather than cluttering up DEPLOY_DIR_IMAGE with content that isn't directly bound to an image.
3 participants
This class is adding the functionality to run scancode utility on code.
You can override SCANCODE_FORMAT if you need json output. It assumes scancode
is present in PATH and is set in HOSTTOOLS.
This belongs to OI-2.
Signed-off-by: H M Irfan Sadiq irfan_sadiq@mentor.com
Signed-off-by: Noor Ahsan noor_ahsan@mentor.com