Skip to content

docs: CreateField comment/message claims AddCustomField in a task throws at CheckNotProcessingDataChanges #602

Closed

Description

@MattGyverLee

CustomFieldOperations.CreateField (System/CustomFieldOperations.py, the comment at ~:292-294 and the raised message at ~:308-311, checked at 562d5f4) says the LCM contract forbids schema mutation inside a data unit of work: "AddCustomField + an active task -> InvalidOperationException at UndoStack.CheckNotProcessingDataChanges".

LCM source does not support that claim. FieldWorks' own Custom Fields dialog runs FieldDescription.UpdateCustomField() inside a non-undoable unit of work (AddCustomFieldDlg.cs:949). FlexToolsMCP repeated that route live on 2026-10-02 (NonUndoableUnitOfWorkHelper.Do + UpdateCustomField), and it raised nothing.

Ask: correct the comment and the error message so they give the real reason CreateField refuses. Behaviour doesn't need to change. A wrong reason in an error message sends callers after the wrong fix.

Low priority: doc and message accuracy.


Found during FlexToolsMCP specs/exclusive-access-gate (MattGyverLee/FlexToolsMCP#343); ledger: specs/exclusive-access-gate/issues/filing-ledger.md. Filing authorized by the maintainer on 2026-10-02.

Activity

  1. added
    bugSomething isn't working
    P3Low: hygiene, docs, coverage gaps, verify tasks, latent traps
    on Oct 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3Low: hygiene, docs, coverage gaps, verify tasks, latent trapsbugSomething isn't working

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions