Skip to content

Fix inline help icons not rendering in React components - #8316

Merged
david-yz-liu merged 3 commits into
masterfrom
fix-react-inline-help
Nov 21, 2026
Merged

david-yz-liu merged 3 commits into
masterfrom
fix-react-inline-help

Conversation

@david-yz-liu

@david-yz-liu david-yz-liu commented Nov 21, 2026 •

Copy link
Copy Markdown
Collaborator

Proposed Changes

(Describe your changes here. Also describe the motivation for your changes: what problem do they solve, or how do they improve the application or codebase? If this pull request fixes an open issue, use a keyword to link this pull request to the issue.)

This PR restores the inline help icons inside React components, which stopped appearing after the React 18 upgrade (#7392). The change incorporates a new React component, InlineHelp, to display these, rather than relying on the DOMContentLoaded listener defined in common/help-system.js.

Screenshots of your changes (if applicable)

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
✨ New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue) X
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
📖 Documentation update (change that updates documentation)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

  • I have updated the project Changelog (this is required for all changes).
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

🤖 Generated with Claude Code

david-yz-liu and others added 3 commits November 21, 2026 16:32
common/help-system.js sets up .inline-help elements on DOMContentLoaded.
Since the React 18 upgrade (#7392), createRoot renders asynchronously, so
React components haven't rendered yet when it runs and their help icons
never appear.

Added an InlineHelp component that renders its own icon and toggles its
text with React state, and used it in GradersManager and StarterFileManager.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coveralls

coveralls commented Nov 21, 2026 •

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 44952730556

Coverage increased (+0.001%) to 91.698%

Details

  • Coverage increased (+0.001%) from the base build.
  • Patch coverage: 3 of 3 lines across 1 file are fully covered (100%).
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 55184
Covered Lines: 51667
Line Coverage: 93.63%
Relevant Branches: 2741
Covered Branches: 1449
Branch Coverage: 52.86%
Branches in Coverage %: Yes
Coverage Strength: 132.37 hits per line

💛 - Coveralls

@david-yz-liu david-yz-liu added this to the v2.10.6 milestone Nov 21, 2026
@david-yz-liu
david-yz-liu merged commit 953f269 into master Nov 21, 2026
15 checks passed
@david-yz-liu
david-yz-liu deleted the fix-react-inline-help branch November 21, 2026 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants