Repository navigation
Assign graders to groups with uncollected submissions when skipping empty submissions - #8315
Merged
david-yz-liu merged 2 commits intoNov 21, 2026
Conversation
…mpty submissions When "Assign graders to collected submissions with no files submitted" was unchecked, groups whose submissions had not yet been collected were skipped along with empty ones. Now only groups whose collected submission is empty are skipped, matching the setting's tooltip. Also clarified the setting's label and documented it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
Coverage Report for CI Build 44951374227Coverage increased (+0.001%) to 91.697%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
(Describe your changes here. Also describe the motivation for your changes: what problem do they solve, or how do they improve the application or codebase? If this pull request fixes an open issue, use a keyword to link this pull request to the issue.)
Fixes #4831.
On the Graders tab, when "Assign graders to groups with no files submitted" is unchecked, assigning graders skipped uncollected submissions but produced the misleading "One or more of the groups selected has no files submitted. Grader not assigned." message.
This PR changes
GradersController#filter_empty_submissionsto only skip groups that have an empty collected submission and to keep groups with no collected submission. I renamed the checkbox label to make the behaviour clearer.Screenshots of your changes (if applicable)
Type of Change
(Write an
Xor a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]into a[x]in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
(Include any questions or comments you have regarding your changes.)
🤖 Generated with Claude Code