Skip to content

Assign graders to groups with uncollected submissions when skipping empty submissions - #8315

Merged
david-yz-liu merged 2 commits into
MarkUsProject:masterfrom
david-yz-liu:grader-assign-uncollected-submissions
Nov 21, 2026
Merged

david-yz-liu merged 2 commits into
MarkUsProject:masterfrom
david-yz-liu:grader-assign-uncollected-submissions

Conversation

@david-yz-liu

@david-yz-liu david-yz-liu commented Nov 21, 2026 •

Copy link
Copy Markdown
Collaborator

Proposed Changes

(Describe your changes here. Also describe the motivation for your changes: what problem do they solve, or how do they improve the application or codebase? If this pull request fixes an open issue, use a keyword to link this pull request to the issue.)

Fixes #4831.

On the Graders tab, when "Assign graders to groups with no files submitted" is unchecked, assigning graders skipped uncollected submissions but produced the misleading "One or more of the groups selected has no files submitted. Grader not assigned." message.

This PR changes GradersController#filter_empty_submissions to only skip groups that have an empty collected submission and to keep groups with no collected submission. I renamed the checkbox label to make the behaviour clearer.

Screenshots of your changes (if applicable) image

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
✨ New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue) X
🎨 User interface change (change to user interface; provide screenshots) Checkbox label text only
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
📖 Documentation update (change that updates documentation) X
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

  • I have updated the project Changelog (this is required for all changes).
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

🤖 Generated with Claude Code

david-yz-liu and others added 2 commits November 21, 2026 16:23
…mpty submissions

When "Assign graders to collected submissions with no files submitted" was
unchecked, groups whose submissions had not yet been collected were skipped
along with empty ones. Now only groups whose collected submission is empty
are skipped, matching the setting's tooltip.

Also clarified the setting's label and documented it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coveralls

coveralls commented Nov 21, 2026 •

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 44951374227

Coverage increased (+0.001%) to 91.697%

Details

  • Coverage increased (+0.001%) from the base build.
  • Patch coverage: 14 of 14 lines across 2 files are fully covered (100%).
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 55181
Covered Lines: 51664
Line Coverage: 93.63%
Relevant Branches: 2739
Covered Branches: 1447
Branch Coverage: 52.83%
Branches in Coverage %: Yes
Coverage Strength: 132.0 hits per line

💛 - Coveralls

@david-yz-liu david-yz-liu added this to the v2.10.6 milestone Nov 21, 2026
@david-yz-liu
david-yz-liu merged commit 543e10b into MarkUsProject:master Nov 21, 2026
10 checks passed
@david-yz-liu
david-yz-liu deleted the grader-assign-uncollected-submissions branch November 21, 2026 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Obtuse error when trying to assign graders to uncollected submissions

2 participants