Skip to content

security: added throttling for login requests - #8306

Open
mrafie1 wants to merge 7 commits into
MarkUsProject:masterfrom
mrafie1:add-throttling
Open

mrafie1 wants to merge 7 commits into
MarkUsProject:masterfrom
mrafie1:add-throttling

Conversation

@mrafie1

@mrafie1 mrafie1 commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Proposed Changes

(Describe your changes here. Also describe the motivation for your changes: what problem do they solve, or how do they improve the application or codebase? If this pull request fixes an open issue, use a keyword to link this pull request to the issue.)

Summary: This PR adds the dependency rack-attack and introduces throttling for login requests.

  • Gemfile & Gemfile.lock
    • Added new gem rack-attack to the list of dependencies
  • config/initializers/rack_attack.rb
    • Config file that represents the throttling rules rack-attack implements
    • Currently, I added only one rule: login/user+ip which restricts username and IP combinations to 5 requests per minute
  • spec/rack/attack_spec.rb
    • Test cases for dependency
      • Tests when a user and IP combination sends more requests than the current limit
      • Tests when a user from a different IP address sends a request for a username that has been locked out for another IP address
      • Tests that throttling doesn't share the limit across different usernames
      • Tests that we don't throttle requests with blank credentials for username and password
Screenshots of your changes (if applicable)

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
✨ New feature (non-breaking change that adds functionality) x
🐛 Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
📖 Documentation update (change that updates documentation)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

  • I have updated the project Changelog (this is required for all changes).
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

Question: Currently, we allow a maximum of 5 requests every minute. Is this reasonable?

Comment: I've tried testing my changes by using a VPN and switching it off, but that didn't work for me. It seems that Localhost sees the same IP address regardless of whether the VPN being on/off.

To test it "manually", I used this:

curl -i -X POST http://localhost:3000/csc108/ \ -H 'X-Forwarded-For: IPHERE' \ -H 'Content-Type: application/x-www-form-urlencoded' \ --data 'user_login=testuser&user_password=wrong'
Replace IPHERE with the desired test IP Address

throttles requests that have user_login and user_password params
@mrafie1
mrafie1 marked this pull request as draft November 19, 2026 18:17
@coveralls

coveralls commented Nov 19, 2026 •

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 44948570366

Coverage increased (+0.005%) to 91.701%

Details

  • Coverage increased (+0.005%) from the base build.
  • Patch coverage: 36 of 36 lines across 2 files are fully covered (100%).
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 55207
Covered Lines: 51690
Line Coverage: 93.63%
Relevant Branches: 2739
Covered Branches: 1447
Branch Coverage: 52.83%
Branches in Coverage %: Yes
Coverage Strength: 131.86 hits per line

💛 - Coveralls

previosuly, checked all POST requests, now only checks requests with username and password attributes present
@mrafie1 mrafie1 changed the title breaking: added throttling for login requests security: added throttling for login requests Nov 21, 2026
@mrafie1
mrafie1 marked this pull request as ready for review November 21, 2026 20:52
@mrafie1
mrafie1 requested a review from david-yz-liu November 21, 2026 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants