Repository navigation
Do app platform - #18
Merged
Merged
Conversation
This seems to be required for DO Apps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Context
Placeholder example below:
Closes Issue codebuddies#128
Right now, on the front-end, we need to pass in a token (i.e. the user needs to be logged in) before they can see a list of resource.
This should be true for when users are creating a resource, but the list of resources on https://cb-react-concept.netlify.com/resources should be available to the public.
Other Related Tickets & Documents (as needed)
Placeholder example: This relates to issue codebuddies#23, and I also filed issue codebuddies#43 as a next step to do after this PR is merged.
Implementation Details
What was your thought process as you changed the code? What does someone need to consider in reviewing it?
Placeholder example:
Placeholder example:
[x] Made GET /resources not protected by authorization
[x] Changed setup for tests to make sure we're not authed for the GET requests, but are authed for POST, PATCH, and search.
[x] Added test to make sure GET /api/v1/resources/{{guid}}/ and GET /api/v1/resources/ requests and search work without a token
[x] Altered tests for GET GET /api/v1/resources/{{guid}}/ and GET /api/v1/resources/ requests and search to ensure that they also work with a token
[x] Added tests to make sure PATCH and POST fail without a token
[x] Added test to make sure DEL fails without a token
New Libraries/Dependancies Introduced (Fill out as needed)
If you have added libraries or other dependancies, please list them (and links to their repos) below:
requirements.txtAny new migration files added?
Did you add tests?
Code added or changed without test coverage or good reason for exemption won't be approved.
Did you add documentation?