Repository navigation
feat(PLATECO-2706): decorate predis client - #9
Closed
serhiidonii wants to merge 12 commits into
Closed
serhiidonii wants to merge 12 commits into
serhiidonii wants to merge 12 commits into
Conversation
feat: update schema context bundle
buchekalex
previously approved these changes
Nov 11, 2025
…orate-predis-client
zakhar-huzenko
previously approved these changes
Nov 11, 2025
alekseytupichenkov
requested changes
Nov 12, 2025
| $this->decorated->clear($schema === $this->resolver->getEnvironmentSchema() ? '' : $schema); | ||
| } | ||
|
|
||
| private function prefixKey(string $key): string |
Contributor
There was a problem hiding this comment.
Question: if SchemaAwarePRedisClient and SchemaAwareRedisAdapter are running at the same time, will they not duplicate the prefix?
| /** | ||
| * @return array<array-key, string> | ||
| */ | ||
| private function getDefaultDecoratedMethods(): array |
Contributor
There was a problem hiding this comment.
I don't like the fact that this will need to be supported, but I don't see a more suitable option.
Contributor
There was a problem hiding this comment.
There is no need to answer or do anything here, just think out loud
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.