Repository navigation
feat(Scrubber): add labels to beacons when scrubbing - #933
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
gamegee
reviewed
Oct 26, 2026
gamegee
reviewed
Oct 26, 2026
gamegee
left a comment
gamegee
left a comment
Collaborator
There was a problem hiding this comment.
Just noticed after few tests, that each label position is computed on its own.
So based on the content it can either appears on the right / left
To me its not blocking, but just to make sure we are aware of this
Contributor
Author
yeah agreed, i dislike the square chart in general, here specifically it doesn't work |
gamegee
reviewed
Oct 27, 2026
gamegee
approved these changes
Oct 27, 2026
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes DLS-1104.
Demo
https://ldls-git-dls-1104-ledgerhq.vercel.app/?path=/docs/react-scrubber--docs#beacon-labels
Screen.Recording.2026-10-22.at.16.35.53.mov