Skip to content

Reorg weak lensing package#661

Open
marcpaterno wants to merge 2 commits into
masterfrom
reorg-weak-lensing-package
Open

Reorg weak lensing package#661
marcpaterno wants to merge 2 commits into
masterfrom
reorg-weak-lensing-package

Conversation

@marcpaterno

@marcpaterno marcpaterno commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

Description

Extract weak-lensing arguments, source logic, and factory classes from the monolithic private module into dedicated private submodules. Keep systematics in a renamed _systematics module and update package re-exports to preserve the public firecrown.likelihood.weak_lensing API, including WeakLensingSystematicFactory.

Update internal and test imports to target the package namespace instead of the old private _weak_lensing module, preserving behavior while improving module boundaries and maintainability.

Type of change

  • Refactoring

Checklist

The following checklist will make sure that you are following the code style and
guidelines of the project as described in the
contributing page.

  • I have run make pre-commit and fixed any issues
  • I have added tests that prove my fix is effective or that my feature works
  • I have made corresponding changes to the documentation
  • I have 100% test coverage for my changes (please check this after the CI system has verified the coverage)

Extract weak-lensing arguments, source logic, and factory classes from
the monolithic private module into dedicated private submodules. Keep
systematics in a renamed _systematics module and update package
re-exports to preserve the public firecrown.likelihood.weak_lensing
API, including WeakLensingSystematicFactory.

Update internal and test imports to target the package namespace
instead of the old private _weak_lensing module, preserving behavior
while improving module boundaries and maintainability.
@codecov

codecov Bot commented Jul 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.0%. Comparing base (0f1f6b4) to head (9b01a6e).
⚠️ Report is 20 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #661   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         146      150    +4     
  Lines        8715     8721    +6     
  Branches     1038     1038           
=======================================
+ Hits         8715     8721    +6     
Files with missing lines Coverage Δ
firecrown/app/sacc/_transform.py 100.0% <100.0%> (ø)
firecrown/likelihood/_two_point.py 100.0% <100.0%> (ø)
firecrown/likelihood/weak_lensing/__init__.py 100.0% <100.0%> (ø)
firecrown/likelihood/weak_lensing/_args.py 100.0% <100.0%> (ø)
firecrown/likelihood/weak_lensing/_factories.py 100.0% <100.0%> (ø)
firecrown/likelihood/weak_lensing/_source.py 100.0% <100.0%> (ø)
firecrown/likelihood/weak_lensing/_systematics.py 100.0% <100.0%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@marcpaterno
marcpaterno requested a review from vitenti July 22, 2026 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant