Generalize Tracer Framework and Add CMB Lensing Support#616
Open
vitenti wants to merge 25 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #616 +/- ##
========================================
Coverage 100.0% 100.0%
========================================
Files 150 151 +1
Lines 8721 8977 +256
Branches 1038 1063 +25
========================================
+ Hits 8721 8977 +256
🚀 New features to boost your workflow:
|
Includes alias for backwards compatibility.
Add related tests.
# Conflicts: # firecrown/likelihood/weak_lensing/_systematics.py # tests/likelihood/gauss_family/statistic/source/test_source.py # tests/likelihood/test_weak_lensing.py
vitenti
marked this pull request as ready for review
July 24, 2026 02:23
marcpaterno
reviewed
Jul 24, 2026
marcpaterno
left a comment
Collaborator
There was a problem hiding this comment.
The only concern I have is with backward compatibility. This PR takes care to support existing code that imports the old names. But we may break user code that relies on existing serialized YAML that contains old class names. Do we need to support reading old serialized data?
I would like to be able to say that we explicitly do not, because I think trying to do so will substantially complicate the code for what I suspect is little value. But perhaps we need to get agreement in a Firecrown/CCL meeting that the value is small.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR generalizes Firecrown's tracer system to support multiple types of projected fields beyond galaxy redshift distributions, with CMB lensing as the first new implementation. The refactoring introduces a flexible
ProjectedFieldprotocol that enables the framework to work with different types of tracers while maintaining backwards compatibility.Fixes #606, #607
Type of change
Checklist:
The following checklist will make sure that you are following the code style and
guidelines of the project as described in the
contributing page.
bash pre-commit-checkand fixed any issues