Skip to content

Cannot save Media Folders with stale mappings #1676

Description

@EdwinKM

Describe the bug
I’m running Lyrion in a container on my TrueNAS system.

Lyrion seems to have trouble when a volume mapping is removed from the Docker Compose file while the corresponding path is still configured as a Media Folder.

It appears that a user cannot remove the stale Media Folder configuration once the underlying mapping no longer exists.

To Reproduce
Make sure the music folders exists!

  • Start with a clean Lyrion configuration.
  • Configure the default /music and /playlist folders.
  • Add /music2 under Menu → Server → Basic Settings → Media Folders.
  • Save the settings and perform the requested library rescan.
  • Stop the container.
  • Disable the following volume mapping in the Compose file:
    - ${USERDIR:-$HOME}/temp/music2:/music2
  • Start the container again.
  • Go to Menu → Server → Basic Settings → Media Folders.
  • Add /music3 and click Save Settings.

See save_after_music3.png.

The result:

  • Lyrion shows a “Changes have been saved” notification, even though the changes were not saved.
  • There is no relevant log entry in docker logs -f lms-en-media.
  • The configuration reverts to the previous state (/music and /music2).
  • The Media Folders UI appears to break: the folder icons disappear.

For comparison:

  • Stop the container.
  • Re-enable the /music2 volume mapping.
  • Start the container again.
  • Add /music3 and uncheck /music2.
  • Save the settings.
  • Lyrion correctly shows “Some settings require a rescan of your library to take effect.”

Expected behavior
A user should be able to remove a Media Folder even when the corresponding directory or Docker volume mapping no longer exists.

At the very least, Lyrion should report an error when it cannot save the configuration, rather than displaying “Changes have been saved” and silently reverting to the previous settings.

Screenshots
Screenshots added

System Information (please complete the following information):

  • See compose file
  • Firefox browser

Additional context
N/A

compose.txt
Image

No activity

Activity on this issue will appear here.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions