Repository navigation
Migrate to crypto_primes for primality test instead of glass_pumpkin for num-bigint backend - #46
Merged
Merged
Conversation
I've taken the only primarity test that we are using in our library from `glass_pumpkin v2.0.0`. I modified the code to work with version of `rand_core` that we depend on. Signed-off-by: Denis Varlakov <cordial.egg6523@fastmail.com>
Signed-off-by: Denis Varlakov <cordial.egg6523@fastmail.com>
Signed-off-by: Denis Varlakov <cordial.egg6523@fastmail.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Signed-off-by: Denis Varlakov <cordial.egg6523@fastmail.com>
Signed-off-by: Denis Varlakov <cordial.egg6523@fastmail.com>
Signed-off-by: Denis Varlakov <cordial.egg6523@fastmail.com>
maurges
requested changes
Oct 15, 2026
Signed-off-by: Denis Varlakov <cordial.egg6523@fastmail.com>
survived
changed the title
glass_pumpkin dependency crypto_primes for primality test instead of glass_pumpkin for num-bigint backend
maurges
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
glass_pumpkinthat we depend on has buggy primality test that identifies certain composite numbers as primes.The latest version of the library does not have this bug, but it uses version of
rand_coreincompatible with our library.Turned out that the latest version of
glass_pumpkinalready usescrypto_primes, so we migrated directly to it.