Iss407 pedestal refactor - #455
Open
duncanswilmot wants to merge 4 commits into
Open
Conversation
tomeichlersmith
requested changes
Aug 10, 2026
tomeichlersmith
left a comment
tomeichlersmith
left a comment
Member
There was a problem hiding this comment.
This is just a first pass - I have not tried to run it myself yet, but the actual algorithm looks good. I just want to avoid one pitfall and drop one extra local variable that I don't believe is necessary.
duncanswilmot
force-pushed
the
iss407-pedestal-refactor
branch
from
August 12, 2026 15:51
66d513e to
9393cb4
Compare
Author
|
I couldn't avoid running into the same issue with variance as standard deviation, so I just attempted to keep is as double the whole way rather than adding new code for a variance function. Does this work? |
tomeichlersmith
left a comment
tomeichlersmith
left a comment
Member
There was a problem hiding this comment.
Can you test that this will ignore channels that we turned off?
You can turn off a channel with
> ROC
> POKE
Page: CH_##
Parameter: CHANNEL_OFF
Value: 1
where ## is the channel number you want to turn off on ROC0.
| settings; | ||
| for (int i_roc : tgt->roc_ids()) { | ||
| for (int ch{0}; ch < 72; ch++) { | ||
| if (basedevs[i_roc].at(ch) == 0) { |
Member
There was a problem hiding this comment.
Suggested change
| if (basedevs[i_roc].at(ch) == 0) { | |
| if (basedevs[i_roc].at(ch) < 0.1) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening a PR but may need to do some extra work before merging.
For local pedestal leveling, change baseline
TRIM_INVfrom0to32, add adaptive support for bothECALandHCALROCs, and mask dead channels (i.e., those with 0 standard deviation). Seeing some difficulty leveling for ECAL (see image). May just be running out of range withTRIM_INV, but someone should try to run this on their own to verify behavior.Note: did not yet test for HCAL