Skip to content

CompatHelper: bump compat for Symbolics in [extras] to 7, (keep existing compat) #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
exaexa merged 5 commits into from
Aug 14, 2026
Merged

CompatHelper: bump compat for Symbolics in [extras] to 7, (keep existing compat) #277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9e9772f
CompatHelper: bump compat for Symbolics in [extras] to 7, (keep exist…
May 2, 2026
3e38a58
fix tests for symbolics 7
exaexa May 2, 2026
cdc112e
push symbolics dep forward
exaexa May 2, 2026
e2a72e0
mark broken
exaexa May 2, 2026
9b49bed
ok let's just provide both variants
exaexa Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "SBML"
uuid = "e5567a89-2604-4b09-9718-f5f78e97c3bb"
authors = ["The developers of SBML.jl"]
version = "1.6"
authors = ["The developers of SBML.jl"]

[deps]
DocStringExtensions = "ffbed154-4ef7-542d-bbb7-c09d3a79fcae"
Expand All @@ -16,7 +16,7 @@ ConstructionBase = "1.3"
DocStringExtensions = "0.8, 0.9"
IfElse = "0.1"
SBML_jll = "5.19.5"
Symbolics = "5,6"
Symbolics = "7"
Unitful = "1"
julia = "1.6"

Expand Down
9 changes: 8 additions & 1 deletion test/loadmodels.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,14 @@ end
m = readSBML(joinpath(@__DIR__, "data", "01565-sbml-l3v1.xml"))

if TEST_SYMBOLICS
@test interpret_as_num(m.reactions["J23"].kinetic_math) == 0.0
# Older versions of symbolics somehow auto-simplify this, newer ones do not.
@variables S23 S23b
@test (
isequal(interpret_as_num(m.reactions["J23"].kinetic_math), 0.0) || isequal(
interpret_as_num(m.reactions["J23"].kinetic_math),
S23 * S23b * log(Num(1)) / log(Num(10)),
)
)

@variables S29 S29b
@test isequal(interpret_as_num(m.reactions["J29"].kinetic_math), 2.0 * S29 * S29b)
Expand Down
Loading