Skip to content

Anthony Calabrese Dev Team application - #541

Open
cala28124-sketch wants to merge 1 commit into
KnightHacks:mainfrom
cala28124-sketch:blade/anthony-calabrese-page
Open

Anthony Calabrese Dev Team application#541
cala28124-sketch wants to merge 1 commit into
KnightHacks:mainfrom
cala28124-sketch:blade/anthony-calabrese-page

Conversation

@cala28124-sketch

Copy link
Copy Markdown

adds a standalone, additive route at /anthony_calabrese with an animated intro curtain, gear/vine/conveyor decorations, and links to resume/linkedin/github/portfolio. scoped entirely to its own route (page.tsx, page.module.css, local font, public assets) with no changes to shared blade files (layout, globals.css, root page).

Why

PR made for dev team application for Anthony Calabrese

What

A small, mini portfolio for the dev team application, modeled under own blade route.

Note

As always, thank you for your time and have a wonderful day.

adds a standalone, additive route at /anthony_calabrese with an
animated intro curtain, gear/vine/conveyor decorations, and links to
resume/linkedin/github/portfolio. scoped entirely to its own route
(page.tsx, page.module.css, local font, public assets) with no
changes to shared blade files (layout, globals.css, root page).

Co-authored-by: Claude <claude@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 6, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Adds a new Next.js page for Anthony Calabrese. The page includes metadata, a local font, a curtain overlay, the KHIX logo, animated factory, piping, gear, and vine backgrounds, a title banner, and four external links. CSS modules define the page layout, opacity transitions, background movement, and gear rotations.

Merge Risk: 🟡 Moderate · up to 690d8

The new application page may leave profile links inaccessible on some viewport sizes or behind decorative layers, while its animations and image labels create accessibility problems. It also contains CSS naming that can fail lint checks, so the page is not ready to merge unchanged.

🚥 Pre-merge checks | ✅ 6 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title describes the page added by the changeset but does not start with a bracketed issue number. Prefix the title with the issue number, for example: "[#123] Anthony Calabrese Dev Team application".
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (6 passed)
Check name Status Explanation
Description check ✅ Passed The description explains the new standalone route, its animated content, links, and scope.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
No Hardcoded Secrets ✅ Passed No hardcoded secrets found. All 11 added blobs were scanned for credential patterns and secret assignments, with no matches. The page literals contain only UI text, asset paths, CSS classes, and publi…
Validated Env Access ✅ Passed No changed file in the pull request uses process.env. The added route files contain no raw environment access, and the existing process.env references are confined to apps/blade/src/env.ts and c…
No Typescript Escape Hatches ✅ Passed The added page.tsx contains no any type, @ts-ignore, @ts-expect-error, or non-null assertion. Text and AST searches found no matches in the changed TypeScript files.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

Some tools did not complete. Review the errors below.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

apps/blade/src/app/anthony_calabrese/page.module.css

ESLint skipped: missing config or dependency (missing-dependency). The ESLint configuration references a package that is not available in the sandbox.

apps/blade/src/app/anthony_calabrese/page.tsx

ESLint skipped: the matched ESLint configuration already failed (missing-dependency).


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Warning

⚠️ This pull request has been flagged as potential spam (promotional) by CodeRabbit slop detection and should be reviewed carefully.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Note

Quiet mode is enabled, so only the most important comments were posted inline. Other review comments are grouped below.

🟡 Other comments (3)
apps/blade/src/app/anthony_calabrese/page.tsx-59-59 (1)

59-59: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Mark decorative images as decorative.

The gear and vine images have nonempty alt text, so screen readers announce them repeatedly. Set their alt value to "". Use alt="KHIX logo" for the logo image.

apps/blade/src/app/anthony_calabrese/page.module.css-8-8 (1)

8-8: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Provide a reduced-motion end state.

Add a prefers-reduced-motion rule that disables animations, sets .curtain1 and .curtain3 to opacity: 0, and sets .curtain2 to opacity: 1.

Also applies to: 27-27, 46-46, 68-68, 90-90, 118-118, 139-139, 156-156, 168-168, 181-181, 194-194

apps/blade/src/app/anthony_calabrese/page.module.css-118-121 (1)

118-121: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Use kebab-case keyframe names.

Stylelint rejects these camelCase keyframe names. Rename each animation reference and matching @keyframes identifier to kebab-case.

  • apps/blade/src/app/anthony_calabrese/page.module.css#L118-L121: rename pipeMove to pipe-move.
  • apps/blade/src/app/anthony_calabrese/page.module.css#L138-L142: rename tkMove to tk-move.
  • apps/blade/src/app/anthony_calabrese/page.module.css#L155-L159: rename gearMoveRight to gear-move-right.
  • apps/blade/src/app/anthony_calabrese/page.module.css#L167-L171: rename gearMoveRightBottom to gear-move-right-bottom.
  • apps/blade/src/app/anthony_calabrese/page.module.css#L180-L184: rename gearMoveLeftBottom to gear-move-left-bottom.
  • apps/blade/src/app/anthony_calabrese/page.module.css#L193-L197: rename gearMoveLeft to gear-move-left.

Source: Linters/SAST tools


ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: QUIET

Plan: Team

Run ID: 9947bbc1-bdc3-45e7-af41-c6499702dbff

📥 Commits

Reviewing files that changed from the base of the PR and between 566b4ee and 690d8f7.

⛔ Files ignored due to path filters (9)
  • apps/blade/public/gear.png is excluded by !**/*.png
  • apps/blade/public/khix-logo-white.svg is excluded by !**/*.svg
  • apps/blade/public/pipefactory.png is excluded by !**/*.png
  • apps/blade/public/sidewalk.svg is excluded by !**/*.svg
  • apps/blade/public/tkgreen.png is excluded by !**/*.png
  • apps/blade/public/vines.png is excluded by !**/*.png
  • apps/blade/public/vines2.png is excluded by !**/*.png
  • apps/blade/public/vines2invert.png is excluded by !**/*.png
  • apps/blade/src/app/anthony_calabrese/fonts/animeace2_reg.ttf is excluded by !**/*.ttf
📒 Files selected for processing (2)
  • apps/blade/src/app/anthony_calabrese/page.module.css
  • apps/blade/src/app/anthony_calabrese/page.tsx

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

Comment on lines +3 to +4
height: 100dvh;
overflow: hidden;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Allow the link list to scroll.

height: 100dvh with overflow: hidden clips links on short or zoomed viewports. Use min-height: 100dvh, overflow-x: hidden, and overflow-y: auto.

<div
className={cn(
styles.boxPulse,
"z-10 flex h-[60dvh] w-[100dvw] flex-col items-center justify-center md:h-[40dvh]",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Layer the link container above the decorations.

z-10 has no effect on this non-positioned block. The fixed z-10 decorations can cover and intercept the links. Add relative z-20 here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant